fix: stop swallowing store-unavailable errors in API-key and TOTP-log… - #1414
Merged
Conversation
…in paths APIKeyService.Resolve and AuthService.CompleteTOTPLogin collapsed a live restore's "store suspended" error into generic not-found/invalid errors, mirroring an earlier UserService bug. Fixed by propagating the distinct LocalizedError instead, plus extending the Bearer-auth middleware (which was otherwise silently discarding the fix) to return 503 without counting the attempt against its rate limiter, and correcting the TOTP-verification metric's bucketing for the same case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in paths
APIKeyService.Resolve and AuthService.CompleteTOTPLogin collapsed a live restore's "store suspended" error into generic not-found/invalid errors, mirroring an earlier UserService bug. Fixed by propagating the distinct LocalizedError instead, plus extending the Bearer-auth middleware (which was otherwise silently discarding the fix) to return 503 without counting the attempt against its rate limiter, and correcting the TOTP-verification metric's bucketing for the same case.