[FB] PMM-7424 db stats in mongo exporter #334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "github.com/percona/mongodb_exporter/internal/tu" | ||
| ) | ||
|
|
||
| func TestDBStatsCollector(t *testing.T) { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Function 'TestDBStatsCollector' is too long (77 > 60) (funlen)
|
|
||
| ti := labelsGetterMock{} | ||
|
|
||
| c := &dbstatsCollector{ |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
ctx, compatibleMode are missing in dbstatsCollector (exhaustivestruct)
| dbNames, err := d.client.ListDatabaseNames(d.ctx, bson.M{}) | ||
| if err != nil { | ||
| d.logger.Errorf("Failed to get database names: %s", err) | ||
| return |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
return with no blank line before (nlreturn)
| err := r.Decode(&dbStats) | ||
| if err != nil { | ||
| d.logger.Errorf("Failed to get $dbstats for database %s: %s", db, err) | ||
| continue |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
continue with no blank line before (nlreturn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-7424 Add dbStats-based metric to mongodb_exporter v0.20+
This is a draft PR to be able to create a feature build for a 3rd party contribution.
DO NOT MERGE
Feature buiild: pmm-submodules PR #1982