Skip to content

Conversation

@DeathBorn
Copy link

from both mongos and mongod side with an option to enable/disable collection/database metrics

@DeathBorn
Copy link
Author

any news?

@AlekSi AlekSi changed the base branch from develop to PMM-1764-small-improvements January 4, 2018 11:50
@AlekSi AlekSi self-assigned this Jan 4, 2018
@percona percona deleted a comment from codecov bot Jan 4, 2018
@percona percona deleted a comment from codecov bot Jan 4, 2018
@codecov
Copy link

codecov bot commented Jan 4, 2018

Codecov Report

Merging #84 into PMM-1764-small-improvements will decrease coverage by 2.43%.
The diff coverage is 0%.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           PMM-1764-small-improvements      #84      +/-   ##
===============================================================
- Coverage                        24.77%   22.33%   -2.44%     
===============================================================
  Files                               35       39       +4     
  Lines                             1990     2207     +217     
===============================================================
  Hits                               493      493              
- Misses                            1473     1688     +215     
- Partials                            24       26       +2
Impacted Files Coverage Δ
mongodb_exporter.go 1.53% <0%> (-0.03%) ⬇️
collector/mongod/database_status.go 0% <0%> (ø)
collector/mongodb_collector.go 53.33% <0%> (-8.21%) ⬇️
collector/mongod/collections_status.go 0% <0%> (ø)
collector/mongos/collections_status.go 0% <0%> (ø)
collector/mongos/database_status.go 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a1cbc...0784113. Read the comment docs.

@AlekSi
Copy link
Contributor

AlekSi commented Jan 4, 2018

I failed to resolve merge conflict in the GitHub UI. Ended up just cherry-picking the commit. Will apply some small fixes in the branch.
Thank you for your contribution! And sorry for a long delay.

@AlekSi AlekSi closed this Jan 4, 2018
@DeathBorn
Copy link
Author

@AlekSi welcome :) waiting for merge

@AlekSi
Copy link
Contributor

AlekSi commented Jan 4, 2018

See #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants