Version 0.4.0 #89
Merged
Version 0.4.0 #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable pre-fetching (not needed on exporter queries), limit conn pool size and re-use database connection to MongoDB * Remove .Ping() on exporter.mongoSess, mgo.Session will recreate the conn for us * avoid race condition with sync.Mutex * Use lock on close of mgo session also * Use lock on close of mgo session also #2 * make pool limit a flag instead of hard-code * default to 1 connection, it seems to work fine even at high volume * Must return .Copy() of mgo.Session to avoid mgo deadlocking under concurrent calls. Moved session SocketTimeout to no longer be forever * Must defer .Close() on copied mgo.Session from .getSession * must check if != nil a 2nd time in getSession()
* Use mutex hat. * Protect Close() with lock too. * Count getSession() errors.
* Added query comments to .Find() queries in oplog_status.go, created shared/utils.go function to add comments, cleaned up duplicated code I made long ago * shorten comment
PMM-1764 Various small improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.