Tims code updates #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
April 11, 2016 11:34
…lsets, removed broken go tests to match upstream, pulled in a few bugfixes
jtharpla
pushed a commit
to closeio/mongodb_exporter
that referenced
this pull request
Oct 26, 2017
AlekSi
pushed a commit
that referenced
this pull request
Jan 4, 2018
* Disable pre-fetching (not needed on exporter queries), limit conn pool size and re-use database connection to MongoDB * Remove .Ping() on exporter.mongoSess, mgo.Session will recreate the conn for us * avoid race condition with sync.Mutex * Use lock on close of mgo session also * Use lock on close of mgo session also #2 * make pool limit a flag instead of hard-code * default to 1 connection, it seems to work fine even at high volume * Must return .Copy() of mgo.Session to avoid mgo deadlocking under concurrent calls. Moved session SocketTimeout to no longer be forever * Must defer .Close() on copied mgo.Session from .getSession * must check if != nil a 2nd time in getSession()
MikaSoinetsalo
added a commit
to Yleisradio/mongodb_exporter
that referenced
this pull request
Dec 10, 2018
MikaSoinetsalo
added a commit
to Yleisradio/mongodb_exporter
that referenced
this pull request
Dec 10, 2018
MikaSoinetsalo
added a commit
to Yleisradio/mongodb_exporter
that referenced
this pull request
Dec 11, 2018
AlekSi
added a commit
that referenced
this pull request
Aug 23, 2020
* Sandbox, Connection and tests * WIP Test push pemissions * .goreleaser, version and debug * Metrics renaming & collecting * PMM-5739 Metrics renamer * Updated job definition * Updated test * PMM-5739 Deleted old sandbox files * PMM-5739 code formatting * PMM-5739 Updated linters for tests * PMM-5739 More comments * PMM-5739 Added comments * PMM-5739 Changes for CR * PMM-5739 Fixes for CR * PMM-5739 Updated tests for CR * PMM-5739 Fixes for CR * Update exporter/metrics.go Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> * PMM-5739 Removed duplicated nolint * WIP re-introduced diagnostic data collector * PT-5739 re-added diagnostic data * PMM-5739 Updated test * PMM-5739 Updated mod * PMM-5739 Updates for CR * PMM-5739 Changes for CR * PMM-5739 Updates for CR * PMM-5739 Changes for CR Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@percona.com> Co-authored-by: Carlos <cfsalguero@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on (or partially duplicates) changes in PR #1. This changeset will be much smaller once that is merged.