Align admin dashboard version for 1.7.0#189
Merged
Merged
Conversation
|
Test on Playground |
1ae6d51 to
46452b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PERFORM_VERSIONwith the1.7.0release branch metadata1.7.0Issue
Validation
php -l tests/bootstrap.php && php -l config/constants.php && php -l phpstan-bootstrap.php && php -l tests/unit-tests/tests-dashboard-payload.php./vendor/bin/parallel-lint config/constants.php phpstan-bootstrap.php tests/bootstrap.php tests/unit-tests/tests-dashboard-payload.php --show-deprecated./vendor/bin/phpcs -s config/constants.php phpstan-bootstrap.php tests/bootstrap.php tests/unit-tests/tests-dashboard-payload.php./vendor/bin/phpunit --dont-report-useless-tests --filter Tests_Dashboard_Payloadcomposer testcomposer lintcomposer phpstanProof
1.6.0atoutput/playwright/perform-169-dashboard.png.DashboardPayload::get_data()readsPERFORM_VERSION, and the focused PHPUnit assertion verifies the payload reports1.7.0.Browser proof gap
options-general.php?page=perform_settingsshows1.7.0and that the Scope Runtime Diagnostics to the Dashboard tab on the 1.7.0 beta settings UI #169 diagnostics behavior remains unchanged.Scope notes
1.7.0.beta.1.