add patch tunnels to device api - #183
Merged
danielspofford merged 1 commit intoMay 4, 2024
Merged
Conversation
jasontwong
force-pushed
the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
from
May 2, 2024 15:38
7fa6911 to
b5199c4
Compare
danielspofford
suggested changes
May 3, 2024
danielspofford
left a comment
danielspofford
left a comment
Contributor
There was a problem hiding this comment.
- Match style of "Configure a tunnel" above it.
- Same thing, look at style of how this shows up for configure a tunnel and match it.
- Full sentences here means period at end.
- Ignore this markup, I was going to say you need to also mark the
statefield itself (not just the overall body) as required, but I changed my mind. I actually think I will comment on the other PR and make sure the update succeeds even when asking to change nothing...
jasontwong
force-pushed
the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
from
May 3, 2024 20:12
b5199c4 to
e7f6a72
Compare
danielspofford
approved these changes
May 4, 2024
danielspofford
deleted the
jwong/eng-1573-implement-device-api-patch-tunnelstunnel_prn
branch
May 4, 2024 03:06
jetm
added a commit
that referenced
this pull request
Aug 15, 2026
The table listed #293 as a separate gate and #183 as draft. #293 is closed - its Tegra BSP staging is the first commit of #292 now - and #183 left draft once the Jetson work supplied the motivation its last unexplained commit was missing. A gate list that names a closed PR teaches a reader to distrust the rest of it. Adding #276 is the substantive part rather than bookkeeping. The verification section asks the reader to read /proc/device-tree on the booted board, and a stock image sets root's password field to `*`, so the board boots to a prompt that cannot be satisfied and the check cannot be run at all. The page was describing a procedure its own supported images block. The dev-login kas overlays are what unblock it, so they are a dependency of this page in the same way the delivery hooks are. Say plainly that this makes the verified image differ from the shipped one. Neither overlay touches the device tree, so the result still holds, but a reader who notices the gap deserves the reasoning rather than having to reconstruct whether it invalidates the check. Signed-off-by: Javier Tia <javier@peridio.com>
jetm
added a commit
that referenced
this pull request
Aug 17, 2026
The table listed #293 as a separate gate and #183 as draft. #293 is closed - its Tegra BSP staging is the first commit of #292 now - and #183 left draft once the Jetson work supplied the motivation its last unexplained commit was missing. A gate list that names a closed PR teaches a reader to distrust the rest of it. Adding #276 is the substantive part rather than bookkeeping. The verification section asks the reader to read /proc/device-tree on the booted board, and a stock image sets root's password field to `*`, so the board boots to a prompt that cannot be satisfied and the check cannot be run at all. The page was describing a procedure its own supported images block. The dev-login kas overlays are what unblock it, so they are a dependency of this page in the same way the delivery hooks are. Say plainly that this makes the verified image differ from the shipped one. Neither overlay touches the device tree, so the result still holds, but a reader who notices the gap deserves the reasoning rather than having to reconstruct whether it invalidates the check. Signed-off-by: Javier Tia <javier@peridio.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.