Skip to content

Conversation

@gsexton
Copy link
Contributor

@gsexton gsexton commented Mar 8, 2025

In particular, you should look at how I'm handling the backlight and let me know if it presents issues.

@codecov
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 75.82090% with 81 lines in your changes missing coverage. Please review.

Project coverage is 52.3%. Comparing base (f007d15) to head (98d1d05).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
aip31068/dev.go 83.3% 25 Missing and 11 partials ⚠️
pca9633/dev.go 73.3% 16 Missing and 11 partials ⚠️
waveshare1602/1602.go 0.0% 18 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #100     +/-   ##
=======================================
+ Coverage   51.8%   52.3%   +0.5%     
=======================================
  Files        102     109      +7     
  Lines      13073   13847    +774     
=======================================
+ Hits        6772    7247    +475     
- Misses      6009    6279    +270     
- Partials     292     321     +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@maruel maruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@gsexton gsexton merged commit 38cb339 into periph:main Mar 15, 2025
10 checks passed
@gsexton gsexton deleted the waveshare1602 branch March 28, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants