videos are missing thumbnails

[edrex]

Currently I have to apologize when demoing from my main store, since I take a lot of video.

Fixed in https://camlistore-review.googlesource.com/#/c/5116/. It would be great to get that landed.

[mpl]

ok, I'll try to refresh that CL soon.
If I get thorough reviews from you (and hopefully another peer), I could probably land that one even if Brad is too busy to look at it.

[mpl]

@edrex PTAL.

I won't land it until @bradfitz has at least reviewed the 2 finer points I'm talking about in the commit msg.

Once that get cleared, I could split it in smaller pieces for easier reviewing, but I've kept it all together for now, so we get the complete picture with it.

That said, I think it's now clean enough that you can quite confidently use it at least for demos.

[edrex]

thanks @mpl! I'll try it out over the weekend and review in detail next week.

[stephens2424]

I took a swing made an attempt at resolving the conflict rebasing this to today's master. The result is on a branch here. Not sure what exactly would be the best way to hand this off, but if you want, I can push to your existing gerrit review (as I accidentally discovered is possible). Another might be, if you do: git rebase origin/master b8fd06ad33d5c5052d1fd8b7949ab104c0d62727, you could git-apply this patch. (nope, my git powers are not that strong...)

[mpl]

@stephens2424 I didn't keep the CL up to date because of a lack of reviewers/interest. And I can't decently land it without anyone committing to properly reviewing it.

If I update it and break it into smaller pieces, are you interested enough to review it?

[stephens2424]

Sure!

[AlbinoDrought]

This was a feature I really wanted to see so I cluelessly ported it to the current version. Here it is if anyone is looking for the same thing: https://github.com/AlbinoDrought/perkeep-video-thumbnails

Also on docker hub at https://hub.docker.com/r/albinodrought/perkeep-video-thumbnails