Fix SAML metadata signing #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterkip
force-pushed
the
bug-61
branch
5 times, most recently
from
ac20e57 to
d33ad04
Compare
timlegge
reviewed
Jul 16, 2022
Contributor
|
Can you rebase? I see you closed out the XML::Sig PR. I may pull it together at some point as it was a good feature. |
This requires an update on XML::Sig (see perl-net-saml2/perl-XML-Sig#40) Fixes: perl-net-saml2#61 Signed-off-by: Wesley Schwengle <wesley@opndev.io>
Some SAML implemenations (such as the Dutch eHerkenning) require a KeyName on the KeyDescriptor node. Signed-off-by: Wesley Schwengle <wesley@opndev.io>
Collaborator
Author
I accidentally removed the branch while doing some cleaning. I resubmitted it. |
timlegge
added a commit
to timlegge/perl-Net-SAML2
that referenced
this pull request
Jul 26, 2022
[ Significant Changes since 0.55 ] - Numerous fixes and cleanups thanks to Wesley Schwengle (waterkip) - Functionality changes mostly limited to Net::SAML2::SP - metadata signing has been improved - updates to github actions - new API for ACS/SLO data in metadata [ Change Log ] - signing metadata is now optional - 8ee4f57 Merge pull request perl-net-saml2#69 from waterkip/GH-46_acs_and_slo_injections - 027d300 fixup! Implement new API for ACS/SLO data in metadata - d81549a Implement new API for ACS/SLO data in metadata - 01d5fb7 Merge pull request perl-net-saml2#67 from waterkip/testsuite-defaults - 7c51e1b Merge pull request perl-net-saml2#68 from waterkip/GH-actions - 10b9ab0 Only use defaults/required attrs in net_saml2_sp() test method - 55d6e5e Install Moose in a seperate action - f4d0718 Run Github actions on pull requests - 7eb44fe Make Math::Pari installable - 1fe7b8b cpanm is provided by the perl images - 7f0c885 Update perl images in the matrix - 915adaa Merge pull request perl-net-saml2#65 from waterkip/GH-cleanup-dist.ini - f754ad7 Merge pull request perl-net-saml2#66 from waterkip/perl-net-saml2GH-46-optional_URIs - b25642f Make some URI's optional in the constructor - f01ef30 Remove dependencies from dist.ini - 57142a1 Merge pull request perl-net-saml2#64 from waterkip/bug-61 - 5e6c0f0 Add ds:KeyName to md:KeyDescriptor/ds:Keyinfo - c6b9dfb Fix SAML metadata signing - b18d316 Add missing pod from PR perl-net-saml2#62 - 9f8cd26 Merge pull request perl-net-saml2#62 from waterkip/sign-metadata_optional - 7e637b7 Make signing metadata optional - beba53f Merge pull request perl-net-saml2#63 from waterkip/cert-text_builder - 493af8c Merge pull request perl-net-saml2#60 from waterkip/sp-defaults - 29503c9 Use builder for _cert_text - 5e94d9c Add defaults to authnreq_signed and want_assertions_signed - c2e49e4 v0.55 - 159332d (tag: 0.55) Bump version for 0.55 release
timlegge
added a commit
that referenced
this pull request
Aug 1, 2022
[ Significant Changes since 0.55 ] - Numerous fixes and cleanups thanks to Wesley Schwengle (waterkip) - Functionality changes mostly limited to Net::SAML2::SP - metadata signing has been improved - updates to github actions - new API for ACS/SLO data in metadata [ Change Log ] - signing metadata is now optional - 8ee4f57 Merge pull request #69 from waterkip/GH-46_acs_and_slo_injections - 027d300 fixup! Implement new API for ACS/SLO data in metadata - d81549a Implement new API for ACS/SLO data in metadata - 01d5fb7 Merge pull request #67 from waterkip/testsuite-defaults - 7c51e1b Merge pull request #68 from waterkip/GH-actions - 10b9ab0 Only use defaults/required attrs in net_saml2_sp() test method - 55d6e5e Install Moose in a seperate action - f4d0718 Run Github actions on pull requests - 7eb44fe Make Math::Pari installable - 1fe7b8b cpanm is provided by the perl images - 7f0c885 Update perl images in the matrix - 915adaa Merge pull request #65 from waterkip/GH-cleanup-dist.ini - f754ad7 Merge pull request #66 from waterkip/GH-46-optional_URIs - b25642f Make some URI's optional in the constructor - f01ef30 Remove dependencies from dist.ini - 57142a1 Merge pull request #64 from waterkip/bug-61 - 5e6c0f0 Add ds:KeyName to md:KeyDescriptor/ds:Keyinfo - c6b9dfb Fix SAML metadata signing - b18d316 Add missing pod from PR #62 - 9f8cd26 Merge pull request #62 from waterkip/sign-metadata_optional - 7e637b7 Make signing metadata optional - beba53f Merge pull request #63 from waterkip/cert-text_builder - 493af8c Merge pull request #60 from waterkip/sp-defaults - 29503c9 Use builder for _cert_text - 5e94d9c Add defaults to authnreq_signed and want_assertions_signed - c2e49e4 v0.55 - 159332d (tag: 0.55) Bump version for 0.55 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires an update on XML::Sig
(see perl-net-saml2/perl-XML-Sig#40)
Fixes: #61
Signed-off-by: Wesley Schwengle wesley@opndev.io