Skip to content

Conversation

@waterkip
Copy link
Collaborator

@waterkip waterkip commented Jul 20, 2022

Supports more control over which indexes go where for AssertionConsumerServices
and you can change which one the default is as well. The old constuctor syntax
is still supported but translated to this new setup.

my $sp = Net::SAML2::SP->new(
      single_logout_service => [
          {
              Binding => BINDING_HTTP_REDIRECT,
              Location => 'https://foo.nl',
          },
      ],
      AssertionConsumerService => [
          # order decides index?
          {
              Binding => BINDING_HTTP_ARTIFACT,
              Location => ...,
              # index 1
          },
          {
              Binding => BINDING_HTTP_POST,
              Location => ...,
              # index 2
              isDefault => 1,
          }
      ],
      ...,
);

Closes: #46

Signed-off-by: Wesley Schwengle wesley@opndev.io

@waterkip waterkip force-pushed the GH-46_acs_and_slo_injections branch from 79f7765 to 7b74fa5 Compare July 20, 2022 22:05
Supports more control over which indexes go where for AssertionConsumerServices
and you can change which one the default is as well. The old constuctor syntax
is still supported but translated to this new setup.

    my $sp = Net::SAML2::SP->new(
          single_logout_service => [
              {
                  Binding => BINDING_HTTP_REDIRECT,
                  Location => 'https://foo.nl',
              },
          ],
          AssertionConsumerService => [
              # order decides index?
              {
                  Binding => BINDING_HTTP_ARTIFACT,
                  Location => ...,
                  # index 1
              },
              {
                  Binding => BINDING_HTTP_POST,
                  Location => ...,
                  # index 2
                  isDefault => 1,
              }
          ],
          ...,
    );

Closes: perl-net-saml2#46

Signed-off-by: Wesley Schwengle <wesley@opndev.io>
@waterkip waterkip force-pushed the GH-46_acs_and_slo_injections branch from 7b74fa5 to d81549a Compare July 20, 2022 22:21
Signed-off-by: Wesley Schwengle <wesley@opndev.io>
@timlegge timlegge merged commit 8ee4f57 into perl-net-saml2:master Jul 24, 2022
timlegge added a commit to timlegge/perl-Net-SAML2 that referenced this pull request Jul 26, 2022
  [ Significant Changes since 0.55 ]

  - Numerous fixes and cleanups thanks to Wesley Schwengle (waterkip)
  - Functionality changes mostly limited to Net::SAML2::SP
  - metadata signing has been improved
  - updates to github actions
  - new API for ACS/SLO data in metadata

  [ Change Log ]

  - signing metadata is now optional
  - 8ee4f57 Merge pull request perl-net-saml2#69 from waterkip/GH-46_acs_and_slo_injections
  - 027d300 fixup! Implement new API for ACS/SLO data in metadata
  - d81549a Implement new API for ACS/SLO data in metadata
  - 01d5fb7 Merge pull request perl-net-saml2#67 from waterkip/testsuite-defaults
  - 7c51e1b Merge pull request perl-net-saml2#68 from waterkip/GH-actions
  - 10b9ab0 Only use defaults/required attrs in net_saml2_sp() test method
  - 55d6e5e Install Moose in a seperate action
  - f4d0718 Run Github actions on pull requests
  - 7eb44fe Make Math::Pari installable
  - 1fe7b8b cpanm is provided by the perl images
  - 7f0c885 Update perl images in the matrix
  - 915adaa Merge pull request perl-net-saml2#65 from waterkip/GH-cleanup-dist.ini
  - f754ad7 Merge pull request perl-net-saml2#66 from waterkip/perl-net-saml2GH-46-optional_URIs
  - b25642f Make some URI's optional in the constructor
  - f01ef30 Remove dependencies from dist.ini
  - 57142a1 Merge pull request perl-net-saml2#64 from waterkip/bug-61
  - 5e6c0f0 Add ds:KeyName to md:KeyDescriptor/ds:Keyinfo
  - c6b9dfb Fix SAML metadata signing
  - b18d316 Add missing pod from PR perl-net-saml2#62
  - 9f8cd26 Merge pull request perl-net-saml2#62 from waterkip/sign-metadata_optional
  - 7e637b7 Make signing metadata optional
  - beba53f Merge pull request perl-net-saml2#63 from waterkip/cert-text_builder
  - 493af8c Merge pull request perl-net-saml2#60 from waterkip/sp-defaults
  - 29503c9 Use builder for _cert_text
  - 5e94d9c Add defaults to authnreq_signed and want_assertions_signed
  - c2e49e4 v0.55
  - 159332d (tag: 0.55) Bump version for 0.55 release
@waterkip waterkip deleted the GH-46_acs_and_slo_injections branch July 27, 2022 17:55
timlegge added a commit that referenced this pull request Aug 1, 2022
  [ Significant Changes since 0.55 ]

  - Numerous fixes and cleanups thanks to Wesley Schwengle (waterkip)
  - Functionality changes mostly limited to Net::SAML2::SP
  - metadata signing has been improved
  - updates to github actions
  - new API for ACS/SLO data in metadata

  [ Change Log ]

  - signing metadata is now optional
  - 8ee4f57 Merge pull request #69 from waterkip/GH-46_acs_and_slo_injections
  - 027d300 fixup! Implement new API for ACS/SLO data in metadata
  - d81549a Implement new API for ACS/SLO data in metadata
  - 01d5fb7 Merge pull request #67 from waterkip/testsuite-defaults
  - 7c51e1b Merge pull request #68 from waterkip/GH-actions
  - 10b9ab0 Only use defaults/required attrs in net_saml2_sp() test method
  - 55d6e5e Install Moose in a seperate action
  - f4d0718 Run Github actions on pull requests
  - 7eb44fe Make Math::Pari installable
  - 1fe7b8b cpanm is provided by the perl images
  - 7f0c885 Update perl images in the matrix
  - 915adaa Merge pull request #65 from waterkip/GH-cleanup-dist.ini
  - f754ad7 Merge pull request #66 from waterkip/GH-46-optional_URIs
  - b25642f Make some URI's optional in the constructor
  - f01ef30 Remove dependencies from dist.ini
  - 57142a1 Merge pull request #64 from waterkip/bug-61
  - 5e6c0f0 Add ds:KeyName to md:KeyDescriptor/ds:Keyinfo
  - c6b9dfb Fix SAML metadata signing
  - b18d316 Add missing pod from PR #62
  - 9f8cd26 Merge pull request #62 from waterkip/sign-metadata_optional
  - 7e637b7 Make signing metadata optional
  - beba53f Merge pull request #63 from waterkip/cert-text_builder
  - 493af8c Merge pull request #60 from waterkip/sp-defaults
  - 29503c9 Use builder for _cert_text
  - 5e94d9c Add defaults to authnreq_signed and want_assertions_signed
  - c2e49e4 v0.55
  - 159332d (tag: 0.55) Bump version for 0.55 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some of the uris are optional

2 participants