[ENHANCEMENT] pyroscope: optimize transformProfileResponse to O(n) - #747
Merged
jgbernalp merged 1 commit intoJul 28, 2026
Merged
Conversation
jgbernalp
reviewed
Jul 23, 2026
Contributor
There was a problem hiding this comment.
It would be good to add a test for this, so we can ensure it does not affect the output.
Contributor
Author
There was a problem hiding this comment.
Is a comparison of outputs with the legacy function and the new one in test cases is what you mean?
Contributor
Author
There was a problem hiding this comment.
I added a set of test cases for the refactor + regression test cases against old implementation
Signed-off-by: luweglarz <lucas.weglarz@amadeus.com>
luweglarz
force-pushed
the
pyroscope-profile-transform-perf
branch
from
July 24, 2026 13:11
c42604b to
d436c72
Compare
jgbernalp
approved these changes
Jul 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There was an explicit todo on this function to optimize from O(n2) to O(n).
The old code rescanned the whole parent level from scratch for every node. Since both levels are already sorted by
start, a single pointer that only moves forward is enough in one pass.Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.