Skip to content

[BUGFIX] Table: align filter rows with table columns - #755

Merged
shahrokni merged 1 commit into
perses:mainfrom
Aln999:fix/table-filter-scroll-alignment
Aug 3, 2026
Merged

[BUGFIX] Table: align filter rows with table columns #755
shahrokni merged 1 commit into
perses:mainfrom
Aln999:fix/table-filter-scroll-alignment

Conversation

@Aln999

@Aln999 Aln999 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Description

This PR fixes the filter row alignment issue when the table is scrolled horizontally. It keeps the filter row aligned with the table columns, ensures the filter widths stay in sync, and fixes the filter search so it matches the displayed values correctly

Changes

  • Added a filter row above the table to filter data column by column.
  • Kept the filter row aligned with the table while scrolling horizontally.
  • Fixed filter column widths so they always match the table columns.
  • Improved filter dropdown positioning so it opens correctly without getting cut off.
  • Made the filter dropdown close when the same filter button is clicked again.
  • Fixed search inside the filter dropdown to search the displayed values correctly.
  • Updated the tests and added the required setup for the new filter row functionality.

Screenshots

Screen.Recording.2026-07-26.230445.mp4

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.

#Relates to perses/perses#3835

@Aln999
Aln999 requested a review from a team as a code owner July 26, 2026 17:39
@Aln999
Aln999 requested review from jgbernalp and removed request for a team July 26, 2026 17:39
@shahrokni
shahrokni self-requested a review July 27, 2026 07:50
Comment thread table/src/components/TablePanel.tsx
Comment thread table/src/components/TablePanel.tsx Outdated
Comment thread table/src/components/TablePanel.tsx Outdated
Comment thread table/src/components/TablePanel.tsx Outdated
@shahrokni

Copy link
Copy Markdown
Contributor

@Aln999
You also need to rebase main

This branch is out-of-date with the base branch
Merge the latest changes from main into this branch

Please let me know if you need help for that

@shahrokni

Copy link
Copy Markdown
Contributor

@Aln999
You have failing pipelines. Please take a look and resolve the issues. The issues are tiny.
Since, the pipeline is not automatically running automatically after every push, you can check the linters, tests, etc locally to make sure that everything is in order before pushing to the remote side.

@shahrokni

Copy link
Copy Markdown
Contributor

@Aln999
There is an old bug here and I am wondering, if this is the best time to get rid of it! However, if it only takes less than an hour!
So, feel free to ignore this one, if it demands some times and effort.
You see the filter button here? The click wouldn't close the filter. Could we fix this?

image

@shahrokni

shahrokni commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

I tested the table PR and your fix amazingly have made it way better! I really appreciate for the contribution. I tried to be picky and find something to complain about but I couldn't! Thank you @Aln999 🚀

@Aln999
Aln999 force-pushed the fix/table-filter-scroll-alignment branch from 576326d to b47b91d Compare August 3, 2026 05:12
@Aln999
Aln999 requested a review from shahrokni August 3, 2026 05:50
Comment thread table/src/components/TablePanel.tsx Outdated
@Aln999
Aln999 force-pushed the fix/table-filter-scroll-alignment branch from 4cd6f6d to b47b91d Compare August 3, 2026 11:26
Signed-off-by: Tanvi Kuchanur <alnk8465@gmail.com>
@Aln999
Aln999 force-pushed the fix/table-filter-scroll-alignment branch from b47b91d to 5b64011 Compare August 3, 2026 11:35
@Aln999
Aln999 requested a review from shahrokni August 3, 2026 12:03
@shahrokni
shahrokni added this pull request to the merge queue Aug 3, 2026
Merged via the queue into perses:main with commit 017221e Aug 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants