[BREAKINGCHANGE] Support module and redefine plugin in a dedicated package#35
Conversation
b42a996 to
3acba59
Compare
…ckage Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
3acba59 to
7789af6
Compare
| @@ -11,25 +11,31 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package common | |||
| package plugin | |||
There was a problem hiding this comment.
Plugins are not specific to dashboard. Should we create a single plugin package, and include the plugin module there as well?
There was a problem hiding this comment.
I would prefer to split the module definition from the plugin definition to avoid a confusion between each definition. Also because in the module you also have a plugin struct.
And yes if you prefer I can add the package plugin at the root of the go folder, since it is not entirely related to the dashboard as you mentioned it.
There was a problem hiding this comment.
I would prefer to split the module definition from the plugin definition to avoid a confusion between each definition. Also because in the module you also have a plugin struct.
Makes sense
And yes if you prefer I can add the package plugin at the root of the go folder, since it is not entirely related to the dashboard as you mentioned it.
yes it will make things more clear
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
2 participants
This PR is defining the module and moving the plugin definition from the package
commonto a dedicated packageplugin.