Improved the Audio Interaction for the Demo #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a useSound command line flag that controls whether to output sound - Changed most talk(…) invocations to run in the background - Added a useAlexa parameter that dictates whether to wait to receive a food name from Alexa - Slightly changed the speech outputs over the course of the demo
Contributor
Author
|
The second commit are some additional changes made for the demo. I'm ambivalent about whether they are included in this PR or not -- I can spin off a separate PR if reviewer(s) prefer. |
egordon
requested changes
Jan 7, 2022
Collaborator
egordon
left a comment
egordon
left a comment
There was a problem hiding this comment.
Making sure that things still work on Gen3.
And a formatting nit (maybe begetting another issue). Otherwise, looks okay.
Contributor
Author
|
Ready for re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merge order should be:
emprise/gen3-integration-->mainamaln/batch_size_params-->main(this should be paired with the corresponding AIKIDO PR)amaln/audio_improvements-->main(The second merge is not a strict dependency, but will make merging easier)