setup.sh: wipe stale per-package .venv dirs before uv sync (#62)#63
Merged
Conversation
`uv run` inside a workspace member with its own .venv directory uses that local venv instead of the shared workspace one. Per-package venvs can be missing transitive deps that the workspace sync would install — silently producing ModuleNotFoundError. This was the root cause that masked the dep-declaration bugs fixed in mj_manipulator#163, ada_mj#38, and geodude#195. Idempotent: re-running setup.sh just deletes any per-package venvs that have re-appeared. Fixes #62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv runinside a workspace member with its own.venv/directory uses that local venv instead of the shared workspace one. Per-package venvs can be missing transitive deps that the workspaceuv syncwould install — silently producingModuleNotFoundError.uv sync. Idempotent.Fixes #62
Test plan
ada_mj/.venv,ada_assets/.venv,mj_manipulator_ros/.venv, re-synced, launchedpython -m ada_mj --demo feeding --visercleanly../setup.shshould not leave any per-package.venvand all CLIs should work with--viser.Out of scope
setup.shdoesn't cloneada_assets/ada_mjeven though they're workspace members. Worth filing separately.