PerspectiveWidget support for new Python API#2658
Merged
Conversation
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
ad6e77c to
0577038
Compare
8b9d1cf to
856ec02
Compare
timkpaine
reviewed
Jul 21, 2024
c9f192d to
bff94ef
Compare
018475a to
08a6553
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PerspectiveWidget. Lots of small changes applied, most notably removal of client-only e.g.client=Truemode, but some care has been taken to maintain the rudiments of 2.10.1's user-facing API, at least so far. I would like to consider removing theViewConfigtraitlets as well in the future, asrestore()is the preferred way to do this from both a usability and performance pov. This component needs a lot more cleanup, this PR just updates the internal API relevant parts.perspective-jupyterlabclient extension assets. These now usematurin's data directory support to package the assets, which are built usingjupyter-packaging'slabextension installwebpack builder.aarch64builds for OSX. I've also added support for this architecture on Linux Provide linux aarch64 wheels #2221, but it is not yet enabled on CI (and hence will not distribute), as I am not sure how we can test it just yet. Suggestions welcome.PerspectiveWidget, these steps were omitted from this PR and included here.perspective-serverandperspective-clienthave been reorganized to allow a new variant of theSessiontype introduced in Perspective Virtual API (Python) #2625,ProxySession, which allows an existingClientinstance to itself act as aSessionfor anotherClient. This change was necessary to supportPerspectiveWidget, as the API was designed for (and remains convenient for) working onTableinstances directly, for which the new API prevents access to the originatingServer._version.pyin the Python package.perspective-jupyterlabandperspective-pythondependency ranges to allow JupyterLab 4. This was already technically supported but will no longer warn of version mismatches.