Merged
Conversation
texodus
force-pushed
the
psp3-docs-and-examples
branch
7 times, most recently
from
57c0901 to
ad56647
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com> # Conflicts: # examples/python-tornado/server.py # rust/perspective-python/Cargo.toml # rust/perspective-python/perspective/__init__.py
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
texodus
force-pushed
the
psp3-docs-and-examples
branch
9 times, most recently
from
36af4df to
bf7aa8e
Compare
timkpaine
reviewed
Jul 9, 2024
timkpaine
reviewed
Jul 9, 2024
| def __init__(self, **kwargs): | ||
| self._server = kwargs.pop("perspective_server") | ||
| self._websocket = kwargs.pop("websocket") | ||
| super().__init__(**kwargs) |
Member
There was a problem hiding this comment.
not needed, also don't need to use kwargs (no inheritance anymore)
timkpaine
reviewed
Jul 9, 2024
| def __init__(self, **kwargs): | ||
| self.server = kwargs.pop("perspective_server") | ||
| self._request = kwargs.pop("request") | ||
| super().__init__(**kwargs) |
Member
There was a problem hiding this comment.
not needed, also don't need to use kwargs (no inheritance anymore)
timkpaine
reviewed
Jul 9, 2024
timkpaine
reviewed
Jul 9, 2024
| server = Server() | ||
| client = Client.from_server( | ||
| server, | ||
| loop_callback=lambda fn, *args: TestAsync.loop.add_callback(fn, *args), |
Member
There was a problem hiding this comment.
all these blocks don't need lambdas anymore
timkpaine
reviewed
Jul 9, 2024
timkpaine
reviewed
Jul 9, 2024
texodus
force-pushed
the
psp3-docs-and-examples
branch
from
bf7aa8e to
5a0ea2e
Compare
texodus
force-pushed
the
psp3-docs-and-examples
branch
25 times, most recently
from
4dc6af2 to
c0d9303
Compare
Signed-off-by: Andrew Stein <steinlink@gmail.com>
Signed-off-by: Andrew Stein <steinlink@gmail.com>
This was referenced Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docsproject to build against the new APIexamplesprojects as well, removing deprecated examples.perspective-pythonAPI for feedback from @timkpaine