Fix mallinfo use#3183
Conversation
Signed-off-by: Alexander Balabin <abalabin@bamfunds.com>
There was a problem hiding this comment.
This change fails to build in CI on GA's Ubuntu 22.04 x86_64 and aarch64 targets, likely due to the Manylinux docker environment these builds run in.
I will merge this if it can be gated to the correct glibc to pass CI, but this means it will not end up in generic wheel builds currently anyway, only when building Perspective from source.
|
To support both mallinfo and mallinfo2 in a single binary, maybe you could use dlsym() to call mallinfo2 when it's available, and otherwise fall back to mallinfo. It would require inlining the definition of the mallinfo2 struct since the header won't define it for glibc < 2.33. |
|
I guess there is no appetite for migrating to I'll have a look at loading mallinfo2 dynamically. |
|
Adding support for
|
|
nope |
fix the use of
mallinfofunction:mallinfo2asmallinfois deprecated and buggy as per https://www.man7.org/linux/man-pages/man3/mallinfo.3.html - the deprecation warning is gone from the build after the change