Generate dummy grammar include in release mode too.#321
Merged
bors[bot] merged 1 commit intopest-parser:masterfrom Oct 31, 2018
birkenfeld:master
Merged
Generate dummy grammar include in release mode too.#321bors[bot] merged 1 commit intopest-parser:masterfrom birkenfeld:master
bors[bot] merged 1 commit intopest-parser:masterfrom
birkenfeld:master
Conversation
CAD97
approved these changes
Oct 31, 2018
Contributor
CAD97
left a comment
CAD97
left a comment
There was a problem hiding this comment.
Looks good to me. We already rely on optimizing out much more complicated structures to toss out the unused unicode tables.
You'll just need to fix generator::tests::generate_complete to not expect the cfg.
The conditional was probably added because it was in the original hint to do this manually in the documentation. There doesn't seem to be a downside since the constant will be thrown away in any case, being unused. Fixes #320.
Contributor
Author
|
Done. |
Contributor
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2018
321: Generate dummy grammar include in release mode too. r=dragostis a=birkenfeld The conditional was probably added because it was in the original hint to do this manually in the documentation. There doesn't seem to be a downside since the constant will be thrown away in any case, being unused. Fixes #320. Co-authored-by: Georg Brandl <georg@python.org>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conditional was probably added because it was in the original
hint to do this manually in the documentation. There doesn't seem
to be a downside since the constant will be thrown away in any
case, being unused.
Fixes #320.