Can lazy message be removed from logging?

[nohwnd]

Logging has lazy message that was selectively used to produce messages that are harder to compute, but I think that later I wrapped every single message in if that checks the visibility. So the laziness is no longer needed, because we will always write the message when we reach the code to write it.

[fflaten]

Different reasons. LazyMessage checks $Scope -in $PesterPreference.Debug.WriteDebugMessagesFrom.Value before evaluation. If removed, we'd have put extra guards in the few places it's being used.

    if ($PesterPreference.Debug.WriteDebugMessages.Value) {
-       Write-PesterDebugMessage -Scope Discovery -LazyMessage { "Found $(@(View-Flat -Block $root).Count) tests in $([int]$root.DiscoveryDuration.TotalMilliseconds)ms" }
+       if('Discovery' -in $PesterPreference.Debug.WriteDebugMessagesFrom.Value) {
+           Write-PesterDebugMessage -Scope Discovery "Found $(@(View-Flat -Block $root).Count) tests in $([int]$root.DiscoveryDuration.TotalMilliseconds)ms"
+       }
        Write-PesterDebugMessage -Scope DiscoveryCore "Discovery done in this container."
    }

Only used two places atm, so I'm fine either way.