Skip to content

Remove unused internal functions #2907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nohwnd merged 4 commits into from
Jul 18, 2026
Merged

Remove unused internal functions #2907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
344a20c
Collect code coverage from Invoke-InNewProcess child processes
nohwnd Jul 18, 2026
a5680b7
Remove unused internal functions
nohwnd Jul 18, 2026
e1a7972
Rename Count-Scopes to Get-ScopeCount
nohwnd Jul 18, 2026
865ad7c
Apply suggestions from code review
nohwnd Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 1 addition & 46 deletions src/Format.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# PESTER_BUILD
# PESTER_BUILD
if (-not (Get-Variable -Name "PESTER_BUILD" -ValueOnly -ErrorAction Ignore)) {
. "$PSScriptRoot/functions/Pester.SafeCommands.ps1"
. "$PSScriptRoot/TypeClass.ps1"
Expand Down Expand Up @@ -27,25 +27,6 @@ function Format-Collection ($Value, [switch]$Pretty) {
'@(' + ($formattedCollection -join $separator) + $(if ($trimmed) { ", ...$($count - $limit) more" }) + ')'
}

function Format-Object ($Value, $Property, [switch]$Pretty) {
if ($null -eq $Property) {
$Property = $Value.PSObject.Properties | & $SafeCommands['Select-Object'] -ExpandProperty Name
}
$valueType = Get-ShortType $Value
$valueFormatted = ([string]([PSObject]$Value | & $SafeCommands['Select-Object'] -Property $Property))

if ($Pretty) {
$margin = " "
$valueFormatted = $valueFormatted `
-replace '^@{', "@{`n$margin" `
-replace '; ', ";`n$margin" `
-replace '}$', "`n}" `

}

$valueFormatted -replace "^@", $valueType
}

function Format-Null {
'$null'
}
Expand Down Expand Up @@ -74,28 +55,6 @@ function Format-Number ($Value) {
[string]$Value
}

function Format-Hashtable ($Value) {
$head = '@{'
$tail = '}'

$entries = $Value.Keys | & $SafeCommands['Sort-Object'] | & $SafeCommands['ForEach-Object'] {
$formattedValue = Format-Nicely $Value.$_
"$_=$formattedValue" }

$head + ( $entries -join '; ') + $tail
}

function Format-Dictionary ($Value) {
$head = 'Dictionary{'
$tail = '}'

$entries = $Value.Keys | & $SafeCommands['Sort-Object'] | & $SafeCommands['ForEach-Object'] {
$formattedValue = Format-Nicely $Value.$_
"$_=$formattedValue" }

$head + ( $entries -join '; ') + $tail
}

function Format-Nicely ($Value, [switch]$Pretty) {
if ($null -eq $Value) {
return Format-Null -Value $Value
Expand Down Expand Up @@ -172,10 +131,6 @@ function Sort-Property ($InputObject, [string[]]$SignificantProperties, $Limit =

}

function Get-DisplayProperty ($Value) {
Sort-Property -InputObject $Value -SignificantProperties 'id', 'name'
}

function Get-ShortType ($Value) {
if ($null -ne $value) {
$type = Format-Type $Value.GetType()
Expand Down
101 changes: 1 addition & 100 deletions src/Pester.Runtime.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# PESTER_BUILD
# PESTER_BUILD
if (-not (Get-Variable -Name "PESTER_BUILD" -ValueOnly -ErrorAction Ignore)) {
. "$PSScriptRoot/Pester.Utility.ps1"
. "$PSScriptRoot/functions/Pester.SafeCommands.ps1"
Expand Down Expand Up @@ -45,7 +45,6 @@ else {
# 'New-PluginObject'
# 'New-BlockContainerObject'


# instances
$flags = [System.Reflection.BindingFlags]'Instance,NonPublic'
$script:SessionStateInternalProperty = [System.Management.Automation.SessionState].GetProperty('Internal', $flags)
Expand Down Expand Up @@ -449,7 +448,6 @@ function Invoke-Block ($previousBlock) {
[Array]::Reverse($frameworkEachBlockTeardowns)
[Array]::Reverse($frameworkOneTimeBlockTeardowns)


# setting those values here so they are available for the teardown
# BUT they are then set again at the end of the block to make them accurate
# so the value on the screen vs the value in the object is slightly different
Expand Down Expand Up @@ -735,7 +733,6 @@ function Invoke-TestItem {
}
}


# setting those values here so they are available for the teardown
# BUT they are then set again at the end of the block to make them accurate
# so the value on the screen vs the value in the object is slightly different
Expand Down Expand Up @@ -868,17 +865,6 @@ function New-EachBlockTeardown {
}

# endpoint for adding a setup for all blocks in the current block
function New-OneTimeBlockSetup {
[CmdletBinding()]
param (
[Parameter(Mandatory = $true)]
[ScriptBlock] $ScriptBlock
)
if (Is-Discovery) {
$state.CurrentBlock.OneTimeBlockSetup = $ScriptBlock
}
}

# endpoint for adding a teardown for all clocks in the current block
function New-OneTimeBlockTeardown {
[CmdletBinding()]
Expand All @@ -905,17 +891,6 @@ function Get-CurrentTest {
$state.CurrentTest
}

function Set-CurrentBlock {
[CmdletBinding()]
param (
[Parameter(Mandatory = $true)]
$Block
)

$state.CurrentBlock = $Block
}


function Set-CurrentTest {
[CmdletBinding()]
param (
Expand All @@ -926,7 +901,6 @@ function Set-CurrentTest {
$state.CurrentTest = $Test
}


function Is-Discovery {
$state.Discovery
}
Expand Down Expand Up @@ -1170,7 +1144,6 @@ function Invoke-ContainerRun {
$result
}


function Discover-Test {
[CmdletBinding()]
param (
Expand Down Expand Up @@ -1216,41 +1189,6 @@ function Discover-Test {
$found
}

function Run-Test {
param (
[Parameter(Mandatory = $true)]
[PSObject[]] $Block,
[Parameter(Mandatory = $true)]
[Management.Automation.SessionState] $SessionState
)

$state.Discovery = $false
$steps = $state.Plugin.RunStart
if ($null -ne $steps -and 0 -lt @($steps).Count) {
Invoke-PluginStep -Plugins $state.Plugin -Step RunStart -Context @{
Blocks = $Block
Configuration = $state.PluginConfiguration
Data = $state.PluginData
WriteDebugMessages = $PesterPreference.Debug.WriteDebugMessages.Value
Write_PesterDebugMessage = if ($PesterPreference.Debug.WriteDebugMessages.Value) { $script:SafeCommands['Write-PesterDebugMessage'] }
} -ThrowOnFailure
}
foreach ($rootBlock in $Block) {
Invoke-ContainerRun -RootBlock $rootBlock -SessionState $SessionState
}

$steps = $state.Plugin.RunEnd
if ($null -ne $steps -and 0 -lt @($steps).Count) {
Invoke-PluginStep -Plugins $state.Plugin -Step RunEnd -Context @{
Blocks = $Block
Configuration = $state.PluginConfiguration
Data = $state.PluginData
WriteDebugMessages = $PesterPreference.Debug.WriteDebugMessages.Value
Write_PesterDebugMessage = if ($PesterPreference.Debug.WriteDebugMessages.Value) { $script:SafeCommands['Write-PesterDebugMessage'] }
} -ThrowOnFailure
}
}

function Invoke-PluginStep {
# [CmdletBinding()]
param (
Expand Down Expand Up @@ -1450,10 +1388,6 @@ function Invoke-ScriptBlock {
}
}





# this is what the code below does
# . $OuterSetup
# & {
Expand All @@ -1468,7 +1402,6 @@ function Invoke-ScriptBlock {
# }
# . $OuterTeardown


$wrapperScriptBlock = {
# THIS RUNS (MOST OF THE TIME) IN USER SCOPE, BE CAREFUL WHAT YOU PUBLISH AND CONSUME!
param($______parameters)
Expand All @@ -1480,8 +1413,6 @@ function Invoke-ScriptBlock {
$______parametersForward = $______parameters
}



try {
if ($______parameters.ContextInOuterScope) {
$______outerSplat = $______parameters.Context
Expand Down Expand Up @@ -1744,10 +1675,6 @@ function Invoke-ScriptBlock {
return $r
}

function Reset-TestSuiteTimer ($o) {

}

function Switch-Timer {
param (
[Parameter(Mandatory)]
Expand Down Expand Up @@ -2347,7 +2274,6 @@ function PostProcess-DiscoveredBlock {
}
}


# if we determined that the block should run we can still make it not run if
# none of it's children will run
if ($b.ShouldRun) {
Expand Down Expand Up @@ -2433,7 +2359,6 @@ function PostProcess-ExecutedBlock {
$Block
)


# traverses the block structure after a block was executed and
# and sets the failures correctly so the aggreagatted failures
# propagate towards the root so if a child test fails it's block
Expand Down Expand Up @@ -2488,11 +2413,8 @@ function PostProcess-ExecutedBlock {
# setup it is easy all the tests in the block are considered failed, with teardown
# not so much, when all tests pass and the teardown itself fails what should be the result?



# todo: there are two concepts mixed with the "own", because the duration and the test counts act differently. With the counting we are using own as "the count of the tests in this block", but with duration the "own" means "self", that is how long this block itself has run, without the tests. This information might not be important but this should be cleared up before shipping. Same goes with the relation to failure, ownPassed means that the block itself passed (that is no setup or teardown failed in it), even though the underlying tests might fail.


$b.OwnDuration = $b.Duration - $testDuration

$b.Passed = -not ($thisBlockFailed -or $anyTestFailed)
Expand Down Expand Up @@ -2708,27 +2630,6 @@ function New-BlockContainerObject {
$c
}

function New-DiscoveredBlockContainerObject {
[CmdletBinding()]
param (
[Parameter(Mandatory)]
$BlockContainer,
[Parameter(Mandatory)]
$Block
)

[PSCustomObject] @{
Type = $BlockContainer.Type
Item = $BlockContainer.Item
# I create a Root block to keep the discovery unaware of containers,
# but I don't want to publish that root block because it contains properties
# that do not make sense on container level like Name and Parent,
# so here we don't want to take the root block but the blocks inside of it
# and copy the rest of the meaningful properties
Blocks = $Block.Blocks
}
}

function Invoke-File {
[CmdletBinding()]
param(
Expand Down
Loading
Loading