Run release tests with -NonInteractive so a missing mandatory parameter fails instead of hanging - #2963
Merged
Conversation
…er fails instead of hanging The release runs the tests as `pwsh -noprofile -c "test.ps1"` nested inside the AzureCLI task, and that host allows prompting. A test that invokes an assertion with a missing mandatory parameter (for example the "Requires Expected" tests on Should-NotBeString, Should-BeFasterThan and Should-BeSlowerThan) then prompts for the value and blocks forever on the agent, instead of throwing the ParameterBindingException the test expects. The PR pipeline runs the same tests through the PowerShell task, which is non-interactive, so they throw and pass there. Add -NonInteractive to the release test run so it behaves the same way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release runs the tests as
pwsh -noprofile -c "test.ps1"nested inside the AzureCLI task, whose host allows prompting. The "Requires Expected" tests on Should-NotBeString, Should-BeFasterThan and Should-BeSlowerThan (#2938) invoke the assertion with the now-mandatory Expected missing, so PowerShell prompts for the value and the release build blocks forever on the agent instead of throwing the ParameterBindingException the test expects.The PR pipeline runs the same tests through the PowerShell task, which is non-interactive, so they throw and pass there. Adding -NonInteractive to the release test run makes it behave the same way. Publish-only script, does not affect the build.
🤖