Declare @docusaurus/plugin-content-docs and @docusaurus/theme-common - #444
Merged
Conversation
Main does not build since #435. The tutorial components and the swizzled theme files from #421 import @docusaurus/plugin-content-docs/client and @docusaurus/theme-common, but neither package is in package.json. They only ever came in transitively through @docusaurus/preset-classic, and yarn hoisted them into a flat node_modules so the imports resolved. pnpm uses a strict layout where a package that is not declared is not resolvable, so the client bundle now fails with 8 "Module not found" errors. Both PRs are green on their own, the combination is what breaks, so neither deploy preview caught it. Verified: pnpm build fails on 1c880e9 and passes with this change. 🤖
nohwnd
added a commit
to fflaten/docs
that referenced
this pull request
Aug 11, 2026
pnpm-lock.yaml conflicted as add/add, this branch and main both created it when migrating off yarn. Regenerated it from the merged package.json instead of resolving by hand, so it now carries main @docusaurus/plugin-content-docs and @docusaurus/theme-common from pester#444 together with @tanstack/react-table 9.1.2 from here. Verified: pnpm build passes, and the five additional-resources pages that use PesterDataTable render their tables. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main does not build since #435.
The tutorial components and the swizzled theme files from #421 import
@docusaurus/plugin-content-docs/clientand@docusaurus/theme-common, but neither package is inpackage.json. They only ever came in transitively through@docusaurus/preset-classic, and yarn hoisted them into a flatnode_modulesso the imports resolved anyway. pnpm uses a strict layout where a package that is not declared is not resolvable, so the client bundle now fails.Both PRs are green on their own, it is the combination that breaks, so neither deploy preview caught it.
pnpm buildon 1c880e9:With this change
pnpm buildpasses. The other@docusaurus/*imports insrcare core aliases, not packages, so they need no entry.🤖