Skip to content

docs: fix stale/broken references and add footer build date - #55

Closed
petercorke wants to merge 3 commits into
mainfrom
docs/fix-deprecated-rank-ref
Closed

docs: fix stale/broken references and add footer build date#55
petercorke wants to merge 3 commits into
mainfrom
docs/fix-deprecated-rank-ref

Conversation

@petercorke

@petercorke petercorke commented Aug 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • `rank()` was deprecated in favour of `rankfilter()`, but the "Rank filter" entry on the algorithms overview page (https://petercorke.github.io/machinevision-toolbox-python/card-algorithms.html) still pointed at the old name. Checked every other deprecated method/property name (21 total, cross-referenced against every `DeprecationWarning` call in the codebase) against every `.rst` file in `docs/source/` -- this was the only stale reference found anywhere.
  • Removed a mention of `CentralCamera.decomposeF`, which doesn't exist anywhere in the codebase and can't meaningfully exist: a fundamental matrix alone can't be decomposed into a relative pose without the camera intrinsics -- that's exactly what `decomposeE` already handles via the standard F -> E (using K) -> pose route. It was left as plain text rather than a `:meth:` cross-reference (presumably to avoid a broken-link build warning), the only trace of it in the repo.
  • Added the Sphinx build date to the footer copyright notice on every page, computed dynamically at build time so it always reflects when the docs were actually built. Also cleaned up the year range from the ambiguous trailing "2020-," to "2020-present," while touching that line. Verified with a real `sphinx-build` (full `docs` extra installed into an isolated venv): renders as "© Copyright 2020-present, Peter Corke: built 2026-08-03." in the built footer, no new warnings introduced.

Test plan

  • Real `sphinx-build` run against these changes; footer renders correctly, no new build warnings
  • N/A otherwise -- docs-only change, no code touched

rank() was deprecated in favour of rankfilter() (see
ImageSpatial.py's DeprecationWarning), but the "Rank filter" entry on
the algorithms overview page still pointed at the old name -- the only
such stale reference anywhere in docs/source (checked every deprecated
method/property name against every .rst file).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Aug 3, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
ErrorProne 1 high

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

petercorke and others added 2 commits August 3, 2026 17:47
decomposeF (fundamental-matrix decomposition) doesn't exist anywhere
in the codebase, and can't meaningfully exist: unlike the essential
matrix, a fundamental matrix alone can't be decomposed into a relative
pose without the camera intrinsics -- that's exactly what
decomposeE already handles, via the standard F -> E (using K) -> pose
route. The mention was plain text (not a :meth: cross-reference,
presumably because it would have been a broken link), the only trace
of this in the entire repo.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Appends the Sphinx build date to the copyright string shown in every
page's footer (pydata-sphinx-theme renders it verbatim as
"© Copyright {{ copyright }}."), computed dynamically via
datetime.date.today() so it tracks whenever the docs are actually
built rather than needing a manual update.

Also switched the year range from the ambiguous trailing "2020-," to
"2020-present," -- the bare trailing hyphen immediately followed by a
comma read as stacked punctuation rather than an intentional
open-ended range.

Verified with a real sphinx-build (full docs extra installed into an
isolated venv): renders as
"© Copyright 2020-present, Peter Corke: built 2026-08-03." in the
built footer, no new warnings introduced.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@petercorke petercorke closed this Aug 3, 2026
@petercorke
petercorke deleted the docs/fix-deprecated-rank-ref branch August 3, 2026 10:49
@petercorke petercorke changed the title docs: fix stale rank() reference in card-algorithms.rst docs: fix stale/broken references and add footer build date Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant