fix: exclude tests/ from Bandit's assert_used (B101) check - #99
Open
petercorke wants to merge 1 commit into
Open
fix: exclude tests/ from Bandit's assert_used (B101) check#99petercorke wants to merge 1 commit into
petercorke wants to merge 1 commit into
Conversation
Bare `assert` is idiomatic pytest style (~45 test-suite uses), not a security concern -- B101 exists to catch assert used for real validation in src/ (asserts vanish under `python -O`), where it's still doing legitimate work (48 findings there, unaffected by this change). Verified with a throwaway venv: `bandit -c pyproject.toml -r src tests` now reports the same 48 issues as `-r src` alone (was 93 combined before this config), and `-r src` alone is unchanged. Codacy's Python engine is Prospector, which wraps Bandit and honours this native pyproject.toml config directly -- no Codacy-side setting needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codacy has been flagging every bare
assertin the test suite (Prospector's Bandit integration, rule B101 "assert_used"). Bareassertis idiomatic pytest style (~45 uses acrosstests/), not a security concern there -- B101 exists to catchassertused for real validation insrc/, where an assert can silently vanish underpython -O. That's still a legitimate 48 findings, untouched by this change (tracked in #41).Fix
Codacy's Python engine is Prospector, which wraps Bandit and honours this native
pyproject.tomlconfig directly -- no Codacy dashboard setting needed.Verified
Throwaway venv,
bandit -c pyproject.toml -r src tests:src/, 45 intests/)-r srcalone.tests/'s contribution is fully suppressed,src/'s is unaffected.🤖 Generated with Claude Code