Skip to content

Conversation

@peterramsing
Copy link
Owner

@peterramsing peterramsing commented Mar 18, 2017

What kind of change is this? (Bug Fix, Feature...)
Feature Enhancement/Bug Fix

What is the current behavior (You can also link to an issue)
There are no reasonable ways to override an offset so if you want to override one with a breakpoint it's difficult.
#294

What is the new behavior this introduces (if any)
Adds more reasonable overrides

  • lost-offset: clear;
  • lost-offset: clear-left;
  • lost-offset: clear-right;
  • lost-offset: clear-top;
  • lost-offset: clear-bottom;

Does this introduce any breaking changes?
Shouldn't

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • Docs have been added or updated

Other Comments

@peterramsing
Copy link
Owner Author

@plesiecki Any thoughts on this so far? I have run this against my smoke test and it feels like it's pretty solid. I can merge this into develop and make a beta version if you'd like to see if it works in your project if you'd like.

@codebysubtract, any thoughts as well?

...I really want to get rid of the !importants that are cluttering this but I think that's going to have to wait. Not all software can be perfect that is shipped. 🚢 😄

@steve-holland
Copy link
Contributor

@peterramsing - Looks good. I would agree about getting rid of the !important flags in the future, I really try and avoid them if at all possible.

@plesiecki
Copy link
Contributor

@peterramsing Unfortunately, I cannot help in this case since I'm not working with lost in current project. Keep up the good work!

@peterramsing peterramsing merged commit cbfc053 into develop Mar 21, 2017
@peterramsing peterramsing deleted the feature/disable-offsets branch June 15, 2017 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants