Two minor bugs: #66
Closed
Two minor bugs: #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. str(command, 'ascii') doesn't work with python2 2. BlockHeaders could not be sent in the headers message because they were misssing a zero at the end
Owner
|
Can you split out that str() issue into a separate pull-req. As for the BlockHeaders one, doesn't msg_deser() need a corresponding read? See https://github.com/bitcoin/bitcoin/blob/master/src/main.cpp#L4350 |
This was referenced Jun 5, 2015
Owner
|
Closing now that you've broken the two fixes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize that this is not the most elegant fix for the BlockHeaders but putting it in another place either broke the block generation or the GetHash for the BlockHeaders.
Anyway, thanks for the great library.