Minor string bug, that doesn't work in python2 #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
added a commit
that referenced
this pull request
Jun 7, 2015
2fbb400 Minor string bug, that doesn't work in python2 (ritzdorf)
Owner
|
Oh, sorry, I should have noticed this earlier but actually this code doesn't make much sense; the API really should throw an exception in this case rather than returning None. Anyway, I merged this, but if you could link me to an example of some code that runs into this so I can think about what would be the right API that'd be much appreciated! Equally, if you want to try fixing it yourself go for it. |
ghtdak
pushed a commit
to ghtdak/python-bitcoinlib
that referenced
this pull request
Dec 1, 2015
2fbb400 Minor string bug, that doesn't work in python2 (ritzdorf) [ yapified by gitreformat (github/ghtdak) on Mon Nov 30 21:12:14 2015 ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in
#66
in a separate pull request.