Add Tripsy and Trakt CLI skills - #21
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds two new agent skills (Trakt CLI and Tripsy CLI): each includes a ChangesAgent Skills Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Pull request overview
Adds two new local CLI agent skills to the shared skill library so agents can safely read/verify Tripsy and Trakt data (and only perform mutations with explicit user intent), plus minimal OpenAI agent metadata for discovery.
Changes:
- Add
tripsy-cliskill documentation with read-first verification patterns and mutation guardrails. - Add
trakt-cliskill documentation with setup guidance, common read commands, and guarded mutation workflow. - Register both skills with
agents/openai.yamlinterface metadata (display name, short description, default prompt).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .config/agent-skills/skills/tripsy-cli/SKILL.md | New Tripsy CLI skill guide emphasizing read-first access checks and guarded itinerary mutations. |
| .config/agent-skills/skills/tripsy-cli/agents/openai.yaml | OpenAI interface metadata for Tripsy CLI skill. |
| .config/agent-skills/skills/trakt-cli/SKILL.md | New Trakt CLI skill guide covering verification reads, setup, common queries, and safe write guardrails. |
| .config/agent-skills/skills/trakt-cli/agents/openai.yaml | OpenAI interface metadata for Trakt CLI skill. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.config/agent-skills/skills/trakt-cli/SKILL.md (1)
35-36: Trakt still acceptsurn:ietf:wg:oauth:2.0:oobfor the PIN/OOB-style headless OAuth flow.Trakt’s OAuth app registration (
https://trakt.tv/oauth/applications/new) still acceptsurn:ietf:wg:oauth:2.0:oobas a Redirect URI for headless/CLI-style apps that use Trakt’s out-of-band/PIN pattern, so line 35 looks supported. If this skill is intended for a browser-less “device authorization” flow instead, document/implement the device flow (/oauth/device/code→/activatewithuser_code→/oauth/device/token) rather than relying on an OOB redirect.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.config/agent-skills/skills/trakt-cli/SKILL.md around lines 35 - 36, The SKILL.md currently lists the Redirect URI value "urn:ietf:wg:oauth:2.0:oob" which Trakt still accepts for PIN/OOB headless CLI flows; either explicitly document that this OOB/PIN flow is supported (keep the URI and add a short note that the skill uses out-of-band PIN auth) or replace the OOB approach by implementing and documenting the Device Authorization flow: call /oauth/device/code, show the /activate URL and user_code to the user, then exchange at /oauth/device/token; update the README and any auth-related functions to use the new endpoints and flow accordingly..config/agent-skills/skills/tripsy-cli/SKILL.md (1)
10-16: ⚡ Quick winMake command examples match the fallback rule.
You document fallback to
command -v tripsy, but the health-check examples hardcode$HOME/.local/bin/tripsy. A short preamble variable (e.g., resolvingTRIPSY_BIN) would keep docs copy-paste safe across environments.Suggested doc patch
- Prove access with a live read before claiming Tripsy works: ```bash -"$HOME/.local/bin/tripsy" doctor -"$HOME/.local/bin/tripsy" auth status --json +TRIPSY_BIN="${HOME}/.local/bin/tripsy" +if [ ! -x "$TRIPSY_BIN" ]; then TRIPSY_BIN="$(command -v tripsy)"; fi +"$TRIPSY_BIN" doctor +"$TRIPSY_BIN" auth status --json</details> <details> <summary>🤖 Prompt for AI Agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.In @.config/agent-skills/skills/tripsy-cli/SKILL.md around lines 10 - 16,
Replace the hardcoded "$HOME/.local/bin/tripsy" examples with a resolved
TRIPSY_BIN variable so the examples follow the documented fallback rule: add a
preamble that sets TRIPSY_BIN to "${HOME}/.local/bin/tripsy" and, if that path
is not executable, set TRIPSY_BIN to the result of "command -v tripsy"; then
invoke TRIPSY_BIN for the health checks shown (the doctor and auth status --json
examples) so the snippets are copy-paste safe across environments.</details> </blockquote></details> </blockquote></details> <details> <summary>🤖 Prompt for all review comments with AI agents</summary>Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.Inline comments:
In @.config/agent-skills/skills/tripsy-cli/SKILL.md:
- Line 72: Clarify and enforce a single canonical timestamp rule in SKILL.md by
replacing the ambiguous phrase "Use exact ISO-8601 UTC datetimes for timed items
plus the localtimezone" with a definitive contract (choose either: a)
UTC-only ISO-8601 strings with trailing Z and a separate optionaltimezone
used only for display, or b) ISO-8601 timestamps that include local offset and a
timezonefield that is purely descriptive), then update all examples in this
document to follow that chosen format consistently and add one short note on how
writers should treat thetimezonefield (display-only vs authoritative) so
readers of the “timestamp contract” cannot perform conflicting conversions.
Nitpick comments:
In @.config/agent-skills/skills/trakt-cli/SKILL.md:
- Around line 35-36: The SKILL.md currently lists the Redirect URI value
"urn:ietf:wg:oauth:2.0:oob" which Trakt still accepts for PIN/OOB headless CLI
flows; either explicitly document that this OOB/PIN flow is supported (keep the
URI and add a short note that the skill uses out-of-band PIN auth) or replace
the OOB approach by implementing and documenting the Device Authorization flow:
call /oauth/device/code, show the /activate URL and user_code to the user, then
exchange at /oauth/device/token; update the README and any auth-related
functions to use the new endpoints and flow accordingly.In @.config/agent-skills/skills/tripsy-cli/SKILL.md:
- Around line 10-16: Replace the hardcoded "$HOME/.local/bin/tripsy" examples
with a resolved TRIPSY_BIN variable so the examples follow the documented
fallback rule: add a preamble that sets TRIPSY_BIN to
"${HOME}/.local/bin/tripsy" and, if that path is not executable, set TRIPSY_BIN
to the result of "command -v tripsy"; then invoke TRIPSY_BIN for the health
checks shown (the doctor and auth status --json examples) so the snippets are
copy-paste safe across environments.</details> <details> <summary>🪄 Autofix (Beta)</summary> Fix all unresolved CodeRabbit comments on this PR: - [ ] <!-- {"checkboxId": "4b0d0e0a-96d7-4f10-b296-3a18ea78f0b9"} --> Push a commit to this branch (recommended) - [ ] <!-- {"checkboxId": "ff5b1114-7d8c-49e6-8ac1-43f82af23a33"} --> Create a new PR with the fixes </details> --- <details> <summary>ℹ️ Review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: Organization UI **Review profile**: CHILL **Plan**: Pro **Run ID**: `4fb4681e-e78a-48e3-ae93-4cc51336db45` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 8390036ac5428cfbe2d94b3b217a1e69f04f519a and f578a501e650cec91c97bb73a7a436e4a4c50d63. </details> <details> <summary>📒 Files selected for processing (4)</summary> * `.config/agent-skills/skills/trakt-cli/SKILL.md` * `.config/agent-skills/skills/trakt-cli/agents/openai.yaml` * `.config/agent-skills/skills/tripsy-cli/SKILL.md` * `.config/agent-skills/skills/tripsy-cli/agents/openai.yaml` </details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f578a501e6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ba39e8a75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Validation
Note
Low Risk
Adds new skill documentation and OpenAI metadata only; no runtime code paths or security-sensitive logic are modified.
Overview
Adds two new personal agent skills,
tripsy-cliandtrakt-cli, to guide Codex in using the local CLIs for Tripsy travel data and Trakt.tv media data.Each skill includes read-first verification steps, common JSON-friendly read commands, and explicit guardrails against unintended mutations, plus
agents/openai.yamlmetadata (display name, short description, default prompt) to expose the skills in OpenAI agent UIs.Reviewed by Cursor Bugbot for commit 76683e7. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Documentation