Avoid reordering of equivalent packages from multiple fetchers - #762
Merged
jsirois merged 1 commit intoSep 11, 2019
Merged
Conversation
clintharrison
force-pushed
the
clint/fetcher-iter-sort-order
branch
from
August 24, 2019 16:57
9028347 to
08e593c
Compare
Contributor
Author
|
Ok, tests are green now. @jsirois do you mind taking a look? |
Eric-Arellano
approved these changes
Sep 10, 2019
Member
|
Thanks @clintharrison - LGTM! |
Member
|
@clintharrison re:
CI currently runs against macos-10.13-xcode9.4.1 so we don't have the 10.14 case covered in an automated way. I don't use OSX so I can't comment either. If you want to post a seperate issue with failures or else do that over in the pantsbuild slack channel #pex, we could dig more. This should work on OSX. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterator.iter()iterates over the set of links returned fromCrawler.crawl(). This means the hash seed randomization potentially changes the order, when there are two packages equivalent in both version, package type (wheel, etc), platform tags, and they're both remote.Ideally, these would not be any different, so it's not really a correctness issue, but I am using pex's resolver internals to store the actual URLs used, and they flap over time between different-but-equivalent ones.
(And in case it's relevant: to be honest I tried running the integration tests locally, but they were failing before this change, and it didn't look related. Are they known to fail on macOS (10.14)?)