Skip to content

Postgres images containing Spock 6.0.0 beta1#24

Merged
maqeel75 merged 3 commits into
mainfrom
spock6-testing
Jul 9, 2026
Merged

Postgres images containing Spock 6.0.0 beta1#24
maqeel75 merged 3 commits into
mainfrom
spock6-testing

Conversation

@maqeel75

@maqeel75 maqeel75 commented Jul 9, 2026

Copy link
Copy Markdown
Member
  • Postgres images containing Spock 6.0.0 beta1

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds amd64 and arm64 package lists for PostgreSQL 16.14, 17.10, and 18.4 with Spock 6.0.0-beta1, adds matching image build entries, and updates the test runner to derive and verify the expected Spock major version.

Changes

Spock 6.0.0-beta1 Package Lists

Layer / File(s) Summary
AMD64 package lists
packagelists/amd64/pg16.14-spock6.0.0-beta1-minimal.txt, packagelists/amd64/pg16.14-spock6.0.0-beta1-standard.txt, packagelists/amd64/pg17.10-spock6.0.0-beta1-*.txt, packagelists/amd64/pg18.4-spock6.0.0-beta1-*.txt
AMD64 minimal and standard package lists are added for PostgreSQL 16.14, 17.10, and 18.4 with Spock 6.0.0-beta1.
ARM64 package lists
packagelists/arm64/pg16.14-spock6.0.0-beta1-minimal.txt, packagelists/arm64/pg16.14-spock6.0.0-beta1-standard.txt, packagelists/arm64/pg17.10-spock6.0.0-beta1-*.txt, packagelists/arm64/pg18.4-spock6.0.0-beta1-*.txt
ARM64 minimal and standard package lists are added for PostgreSQL 16.14, 17.10, and 18.4 with Spock 6.0.0-beta1.

Image Build Wiring and Version-Aware Testing

Layer / File(s) Summary
Build image entries
scripts/build_pgedge_images.py
make_all_flavor_images(...) entries are added for the PostgreSQL 16, 17, and 18 Spock 6.0.0-beta1 image sets, covering the minimal and standard flavors.
Spock version detection and assertions
tests/main.go
main() derives spockMajor from the image tag, passes it through extension test execution and summary reporting, and adds a suite check that queries pg_extension for the installed spock version.

Poem

A rabbit hops through lists of nine,
Sixteen, seventeen, eighteen — all in line! 🐇
Spock beta-one now joins the crew,
Build entries land, and tests do too.
Thump thump — the burrow checks it true!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the new Spock beta1 PostgreSQL images.
Description check ✅ Passed The description directly matches the added Spock beta1 Postgres images.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch spock6-testing

Comment @coderabbitai help to get the list of available commands.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
tests/main.go (1)

189-189: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

buildTestSuite(spockMajor) is built twice per run.

runExtensionTests and printSummary each independently call buildTestSuite(spockMajor) to get the same test list — once to run tests, once just to count them for the summary. Consider computing the suite once in main() and passing it to both functions to avoid rebuilding it.

Also applies to: 198-199

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/main.go` at line 189, `buildTestSuite(spockMajor)` is being recomputed
multiple times for the same run. Update `main()`, `runExtensionTests`, and
`printSummary` so the suite is built once and passed through to both consumers
instead of calling `buildTestSuite(spockMajor)` independently. Use the existing
`buildTestSuite` symbol and the `runExtensionTests`/`printSummary` call sites to
thread the cached suite into both paths.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/main.go`:
- Line 189: `buildTestSuite(spockMajor)` is being recomputed multiple times for
the same run. Update `main()`, `runExtensionTests`, and `printSummary` so the
suite is built once and passed through to both consumers instead of calling
`buildTestSuite(spockMajor)` independently. Use the existing `buildTestSuite`
symbol and the `runExtensionTests`/`printSummary` call sites to thread the
cached suite into both paths.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca5b5e9d-38d1-43d2-9da0-a7792cff7193

📥 Commits

Reviewing files that changed from the base of the PR and between acf9485 and 6c8b67c.

📒 Files selected for processing (14)
  • packagelists/amd64/pg16.14-spock6.0.0-beta1-minimal.txt
  • packagelists/amd64/pg16.14-spock6.0.0-beta1-standard.txt
  • packagelists/amd64/pg17.10-spock6.0.0-beta1-minimal.txt
  • packagelists/amd64/pg17.10-spock6.0.0-beta1-standard.txt
  • packagelists/amd64/pg18.4-spock6.0.0-beta1-minimal.txt
  • packagelists/amd64/pg18.4-spock6.0.0-beta1-standard.txt
  • packagelists/arm64/pg16.14-spock6.0.0-beta1-minimal.txt
  • packagelists/arm64/pg16.14-spock6.0.0-beta1-standard.txt
  • packagelists/arm64/pg17.10-spock6.0.0-beta1-minimal.txt
  • packagelists/arm64/pg17.10-spock6.0.0-beta1-standard.txt
  • packagelists/arm64/pg18.4-spock6.0.0-beta1-minimal.txt
  • packagelists/arm64/pg18.4-spock6.0.0-beta1-standard.txt
  • scripts/build_pgedge_images.py
  • tests/main.go

@maqeel75
maqeel75 requested a review from mmols July 9, 2026 09:00
@maqeel75 maqeel75 changed the title Postgres Images containing Spock 6.0.0 beta1 Postgres images containing Spock 6.0.0 beta1 Jul 9, 2026
@maqeel75
maqeel75 merged commit a2d4143 into main Jul 9, 2026
28 checks passed
@maqeel75
maqeel75 deleted the spock6-testing branch July 9, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants