Add in-repo release workflow and spock50 RPM/DEB packaging - #549
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Up to standards ✅🟢 Issues
|
danolivo
left a comment
There was a problem hiding this comment.
The same as for PR#550. Basically, looks good
Summary
Adds an in-repo release pipeline for the v5 series, so Spock's RPMs and DEBs are
built from this repo on a tag push instead of out of
pgedge-enterprise-packages.Packaging files are taken from that repo's
spock50/component; the workflowfollows the
pgedge-postgres-mcp/pgedge-rag-servershape..github/workflows/release.yml— 7 jobs:detect-matrix → determine-repo-type → package-rpm/package-deb → push-dnf/push-apt → publish-manifestacross almalinux 9/10 and jammy/noble/resolute/bullseye/bookworm/trixie, amd64 + arm64.
Notable choices
PER_PG_VERSION=true, but this repo has nopostgresql-N/dirs, so the PG list can't be auto-discovered — passed explicitly, default
16,17,18, overridable per run. Artifact names carry the PG major so the threePG cells of one (os, arch) don't collide.
COMPONENT_NAME=spock50, not the repo name, so v5 and v6 never share an S3backup path or
_pending/manifest key.git archives intorelease-artifacts/, which the build scripts prefer over cloning the tag.Packages are the exact commit under test, and
simulate_tagbranch runs work.v5.*plus an assert thatinclude/spock.hSPOCK_VERSIONequals the tag version and is5.x.5.0.11~rc1-1.noblenow sorts below
5.0.11-1.noble.debian/patches/—pkglibdir.patchtargets aspock_create_subscriberrecipe that no longer exists and does not apply.