Wait for shutdown instead of assuming it took under a second - #1303
Merged
Conversation
The shutdown test sleeps one second and fails if pgdog is still running. Draining the pools takes as long as it takes, and on a busy runner that is sometimes more than a second, so the job fails for no reason: the log shows every server connection closed, then "Shutdown failed" one second later, then the process exiting. Poll for up to ten seconds instead. A pooler that really doesn't shut down still fails the test, it just no longer depends on how loaded the runner is.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
integration/complex/shutdown.shsleeps for one second after asking PgDog to shut down, then fails the job if the process is still around. Draining the pools takes as long as it takes, and on a busy runner that is sometimes longer than a second, so the job fails with nothing actually wrong.From a recent run — every server connection is closed, the check fires one second later, and the process exits right after:
It has failed this way on
mainas well (e37160da), and it flips between runs of the same commit.Fix
Poll for up to ten seconds instead of guessing. A pooler that genuinely doesn't shut down still fails the test — it just no longer depends on how loaded the runner is.
Verified against a process that exits immediately (returns at once), one that exits after 2.5s (previously a failure, now passes), and one that never exits (still fails, after ~10s).