Stop testing implementation detail of exact transaction count - #1304
Merged
Conversation
This test is purely trying to test that 2pc works. If the data was inserted correctly, appears where we expect it to be, and the 2pc stats are correct, we don't need to concern ourselves with exactly how many health checks and/or schema queries ran during that time.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
reviewed
Aug 3, 2026
| func assertShowFieldGt(t *testing.T, query string, field string, value int64, user string, database string, shard int64, role string) { | ||
| actualValue := showField(t, query, field, user, database, shard, role) | ||
| assert.Contains(t, values, actualValue, fmt.Sprintf("\"%s\" in %s is not one of %v", field, query, values)) | ||
| assert.Greater(t, value, actualValue, fmt.Sprintf("\"%s\" in %s is not greater than %d", field, query, value)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is purely trying to test that 2pc works. If the data was inserted correctly, appears where we expect it to be, and the 2pc stats are correct, we don't need to concern ourselves with exactly how many health checks and/or schema queries ran during that time.