Don't require RELOAD to keep exactly the same connection count - #1305
Merged
Conversation
The goal of this test to ensure that the existing connections are reused when `RELOAD` is issued. However, the exact number of connections needed to perform schema loading might differ slightly each time depending on the exact timing of when the queries complete. It's fine if the connection count increases slightly, we mostly want to make sure it doesn't double. 10% should give us enough wiggle room for this test to test what it's trying to test without breaking as implementation details change
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
approved these changes
Aug 3, 2026
levkk
left a comment
levkk
left a comment
Collaborator
There was a problem hiding this comment.
Disagree on premise, but agree that having a flaky test is disruptive and not worth the noise.
The idea of this test is very important: we need to be sure that RELOAD works adequately, i.e., connection count remains the same. I think the way to test this reliably is to have the pool at full capacity during reload, so no new connections can be created.
That way, if we see 10% more, that's definitely a bug.
Anyway, this is good as is, just keep it in the back of your mind for when you have a second. We might have unit test coverage for this as well, so this is completely fine to merge as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this test to ensure that the existing connections are reused when
RELOADis issued. However, the exact number of connections needed to perform schema loading might differ slightly each time depending on the exact timing of when the queries complete. It's fine if the connection count increases slightly, we mostly want to make sure it doesn't double. 10% should give us enough wiggle room for this test to test what it's trying to test without breaking as implementation details change