Yeet the old parser into the sun - #1324
Merged
Merged
Conversation
Maintaining the duplicate code paths has become a maintenance nightmare. It's time to promote the new parser to just "the parser"
Contributor
Author
|
We're already verifying that the plugins compiled against the same version of `pgdog_plugin`. Types from a different version of the same library are considered different types, so attempting to use a different version of `pg_raw_parse` will result in a compiler error
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
levkk
approved these changes
Aug 7, 2026
levkk
left a comment
levkk
left a comment
Collaborator
There was a problem hiding this comment.
An end to an epic journey. Please do us the honors.
IgorOhrimenko
added a commit
to IgorOhrimenko/pgdog
that referenced
this pull request
Aug 7, 2026
main dropped the second parser in pgdogdev#1324, and this branch still carried the changes for both. Resolving the rebase left one cfg_select! block and a stray blank line behind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining the duplicate code paths has become a maintenance nightmare. It's time to promote the new parser to just "the parser"