bugfix #7 : delete useless "k" and "j" char in manual mode, indeed "…#13
Merged
tianzhou merged 1 commit intoJul 11, 2026
Merged
Conversation
…eed "up" and "down" is enough.
There was a problem hiding this comment.
Pull request overview
This PR aims to fix issue #7 in the connection dialog’s manual input mode by ensuring certain keys (notably j/k) are not consumed as navigation shortcuts, so they can be typed as normal characters.
Changes:
- Removed
j/khandling from connection dialog navigation so those characters can be entered in manual mode. - Minor formatting-only adjustments (alignment/spacing) in a few places.
Comments suppressed due to low confidence (1)
internal/app/app.go:3284
- In manual mode, the "/" key is still intercepted by
case "/", "ctrl+f"and the handler returns without delegating toconnectionDialog.Update, which means users still can’t type "/" (part of issue #7). Similarly,up/downare consumed even in manual mode. Consider only handling these keys in discovery mode and delegating to the text input whenManualModeis true.
case "/", "ctrl+f":
// Enter search mode (only in discovery mode)
if !a.connectionDialog.ManualMode {
a.connectionDialog.EnterSearchMode()
}
return a, nil
case "up":
if !a.connectionDialog.ManualMode {
a.connectionDialog.MoveSelection(-1)
}
return a, nil
case "down":
if !a.connectionDialog.ManualMode {
a.connectionDialog.MoveSelection(1)
}
return a, nil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2121
to
2124
| Width(a.state.Width-2). | ||
| Background(lipgloss.Color("#313244")). | ||
| Foreground(lipgloss.Color("#cdd6f4")). | ||
| Border(lipgloss.RoundedBorder()). |
Comment on lines
+2217
to
2220
| Width(a.state.Width-2). | ||
| Background(lipgloss.Color("#313244")). | ||
| Foreground(lipgloss.Color("#cdd6f4")). | ||
| Border(lipgloss.RoundedBorder()). |
tianzhou
approved these changes
Jul 11, 2026
tianzhou
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bugfix #7 : delete "k" and "j" char indeed "up" and "down" is enough.