Fix bug in pc_patch_uncompressed_from_lazperf#215
Merged
elemoine merged 5 commits intopgpointcloud:masterfrom Jun 12, 2018
Merged
Fix bug in pc_patch_uncompressed_from_lazperf#215elemoine merged 5 commits intopgpointcloud:masterfrom
elemoine merged 5 commits intopgpointcloud:masterfrom
Conversation
added 2 commits
June 11, 2018 21:50
pc_patch_uncompressed_from_lazperf needs to set patch->datasize.
Contributor
Author
|
I suggest to create a v1.1.1 release when this is merged. |
Member
|
@elemoine Do you think that we could add a unit test covering this issue?
👍 |
Contributor
Author
Good call! I extended one of the existing lazperf unit tests, and I added a |
Member
It's perfect, thanks @elemoine! |
pblottiere
approved these changes
Jun 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a major bug in
pc_patch_uncompressed_from_lazperfpreventingPC_Uncompressfrom working on LAZ-compressed patches.This is what we currently get when calling
PC_Uncompresson a LAZ-compressed patch:The bug is that
pc_patch_uncompressed_from_lazperfdoesn't setdatasizeon the uncompressed patch. This PR fixes it.