fix(cli): isolate temporary config paths#36
Merged
phaethix merged 1 commit intoJul 19, 2026
Conversation
Give each TempConf instance a process-local atomic suffix so tests can safely reuse descriptive names under parallel execution. Add a regression that verifies same-name configs keep distinct paths and contents.\n\nCloses phaethix#35.
Owner
|
Thanks for picking this up, @floze-the-genius! The atomic-id approach is exactly the fix the linked issue (#35) called for, and the added regression test is the right call. I verified it locally (fmt + clippy + full test suite all green) and will merge once CI passes. Appreciate the clean, well-scoped contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the CLI test helper assign a unique path to every temporary config, even when parallel tests reuse the same descriptive name.
Motivation
TempConfpreviously keyed paths only by the caller-provided name and process ID. Reusing a name inside one test binary caused one instance to overwrite or delete another instance's file.Closes #35.
Changes
TempConfpathCompatibility Check
FerrumKV targets RESP2 / Redis semantics. If this change touches wire behaviour or command semantics:
FERRUM-NNNissue.Quality Gates — all must pass before requesting review
cargo fmt --all -- --check cargo clippy --all-targets --all-features -- -D warnings cargo test --all-targets --all-features cargo bench --no-run --all-featurescargo fmt --checkcleancargo clippy -- -D warningscleancargo testgreencargo bench --no-runcompilesunsafe(or each block has a// SAFETY:justification)String/strin the data pathtrack_remove+aof.append_del(if AOF)Test Plan
masterbecause both same-name instances resolve to the same pathcargo test temp_conf_paths_are_unique_for_reused_names -- --nocaptureAI Assistance Disclosure
This pull request was implemented and validated with OpenAI Codex. The issue selection, repository policy checks, code changes, tests, and PR text were AI-assisted.