Skip to content

Improved Phalcon\Config\Adapter\Ini#11886

Closed
dred86 wants to merge 2 commits intophalcon:masterfrom
dred86:custom
Closed

Improved Phalcon\Config\Adapter\Ini#11886
dred86 wants to merge 2 commits intophalcon:masterfrom
dred86:custom

Conversation

@dred86
Copy link
Copy Markdown
Contributor

@dred86 dred86 commented Jun 14, 2016

I've modified Ini.zep

@dred86 dred86 mentioned this pull request Jun 14, 2016
@mruz
Copy link
Copy Markdown
Contributor

mruz commented Jun 14, 2016

Add strtolower

if ini === "true" || ini === "yes" || strtolower(ini) === "on"{
...

and fix a test #11863 (comment)

Add strtolower for "On" and "Off" values
* @param mixed ini The array casted by `parse_ini_file`
* @return mixed
*/
private function _cast(ini)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. -> var and remome @return
  2. after a few months it is likely the @link will not be valid (at least line number)

@sergeyklay
Copy link
Copy Markdown
Contributor

@dred86

@dred86
Copy link
Copy Markdown
Contributor Author

dred86 commented Jun 15, 2016

Sorry I do not know yet how to use git

@dred86
Copy link
Copy Markdown
Contributor Author

dred86 commented Jun 15, 2016

@sergeyklay sergeyklay changed the title Update ini.zep Improved Phalcon\Config\Adapter\Ini Jun 15, 2016
@sergeyklay
Copy link
Copy Markdown
Contributor

We don't add changes directly to stable branches or master. You have to send this PR to the 2.1.x branch. Also note to the comments

@sergeyklay sergeyklay closed this Jun 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants