Fixed #13552: Overwriting columns with the same alias#13663
Merged
niden merged 2 commits intophalcon:4.0.xfrom Dec 22, 2018
Merged
Fixed #13552: Overwriting columns with the same alias#13663niden merged 2 commits intophalcon:4.0.xfrom
niden merged 2 commits intophalcon:4.0.xfrom
Conversation
e118ee8 to
a4865ae
Compare
sergeyklay
reviewed
Dec 13, 2018
Member
|
@CameronHall Something wrong with the tests bud. |
a4865ae to
fbabafd
Compare
fbabafd to
e851f48
Compare
sergeyklay
added a commit
that referenced
this pull request
May 7, 2020
See: - #14657 - #13663 /cc @CameronHall
5 tasks
niden
pushed a commit
that referenced
this pull request
May 16, 2020
See: - #14657 - #13663 /cc @CameronHall
niden
pushed a commit
that referenced
this pull request
May 31, 2020
See: - #14657 - #13663 /cc @CameronHall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following (please check boxes):
Small description of change: Fixed
Phalcon\Mvc\Model\Query::_prepareSelectoverwriting columns with the same alias. This specific issue only appeared when you were selecting columns acrossdifferent tables with the same column name. The generated alias didn't factor in the different tables and any columns with the same name would get overridden.
Take this example from
Phalcon\Test\Integration\Paginator\Adapter::testIssue13552. This snippet would generate the SQL below when the paginator tries to find out the total items.Before:
After:
Thanks