[#16052] Fix Query balias lcfirst for namespaced models#16909
Merged
niden merged 1 commit intophalcon:5.0.xfrom Apr 23, 2026
Merged
[#16052] Fix Query balias lcfirst for namespaced models#16909niden merged 1 commit intophalcon:5.0.xfrom
niden merged 1 commit intophalcon:5.0.xfrom
Conversation
…espaced models When building a complex resultset from SELECT * or SELECT alias.*, the balias key used to access the model object inside a Row was always computed with lcfirst(modelName). For namespaced models this produced an unintuitive and hard-to-predict key (e.g. app\Models\Users instead of App\Models\Users). Non-namespaced models (e.g. Robots -> robots) are unaffected. Fixes phalcon#16052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
find()with acolumnsoption that triggers a complex resultset (e.g.'*, "ready" AS stat'), the model object is stored inside theRowunder a key computed from its class name. The key was always built withlcfirst(modelName), which works fine for non-namespaced models (Robots→robots) but produces a confusing, hard-to-predict result for namespaced models (App\Models\Users→app\Models\Usersinstead ofApp\Models\Users).Users had to work around this by calling
lcfirst(\App\Models\Users::class)themselves:Changes
phalcon/Mvc/Model/Query.zep—getSelectColumn(): when computingbaliasforPHQL_T_STARALL(SELECT *) andPHQL_T_DOMAINALL(SELECT alias.*), applylcfirst()only when the model name contains no namespace separator (\); otherwise use the model name as-is.tests/database/Mvc/Model/QueryTest.php— removed thelcfirst()workaround from thetransform()helper that was relying on the old behaviour.Backward compatibility
Non-namespaced model names (e.g.
Robots,Invoices) continue to produce the samelcfirst()key as before (robots,invoices). Only namespaced models are affected.Related
Fixes #16052