Conversation
peterHoburg
reviewed
Jan 16, 2026
| self._sync_client = sync or httpx.Client(**self.client_options) | ||
| self._async_client = async_client or httpx.AsyncClient(**self.client_options) | ||
|
|
||
| def build_client(self) -> httpx.Client: |
Contributor
There was a problem hiding this comment.
The naming of this doesn't make sense. The client is actually built on 31, this just returns it.
| async_client: httpx.AsyncClient | None = None, | ||
| ) -> None: | ||
| self.client_options = client_options or {} | ||
| self._sync_client = sync or httpx.Client(**self.client_options) |
Contributor
There was a problem hiding this comment.
Should this be eager, or should it be just in time when the client is called for the first time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change summary
Introduces HTTP Backends as a new concept.
Fully backwards compatible.
Related issue(s)
#172 is the discussion where this is being considered.
Pull request tasks
The following have been completed for this task:
make testmake formatmake tymake generate-test-clients