Skip to content

Add fallback type on get_type when handling DataType.ARRAY#208

Merged
phalt merged 2 commits intophalt:mainfrom
justmatias:add-fallback-type-for-lists
Mar 26, 2026
Merged

Add fallback type on get_type when handling DataType.ARRAY#208
phalt merged 2 commits intophalt:mainfrom
justmatias:add-fallback-type-for-lists

Conversation

@justmatias
Copy link
Copy Markdown
Contributor

Change summary

  • Increased test coverage for the get_type utility in the standard generator.
  • Added explicit tests for handling OpenAPI array types, including the fallback to typing.Any when the items property is missing from the schema.
  • Added tests to verify correct list[T] generation.

Related issue(s)

#207

Pull request tasks

The following have been completed for this task:

  • Code changes
  • Tests written
  • Documentation changes for new or changed features
  • Pre-review preparation
    • make test
    • make format
    • make ty
    • make generate-test-clients
      • Test clients have changed because a new feature was introduced
      • Test clients remain the same
  • Changelog updated
  • Contributors updated

…typing.Any` for unspecified items and add corresponding tests.
@justmatias
Copy link
Copy Markdown
Contributor Author

@phalt I've noticed that this was never merged. It's possible to merge it.
Feel free to do so if you still think it's a good fix :).

@phalt
Copy link
Copy Markdown
Owner

phalt commented Mar 26, 2026

@justmatias hello sorry, honest answer is I just forgot! Life got in the way.

@phalt phalt merged commit a7bb609 into phalt:main Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants