fix: safely quote injected object JSON#48
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe change adds platform-specific JavaScript string quoting for ChangesInjected object quoting
Sequence Diagram(s)sequenceDiagram
participant NativeWebView
participant StringQuoter
participant JavaScriptBridge
participant WebPage
NativeWebView->>StringQuoter: quote injected object JSON
StringQuoter-->>NativeWebView: escaped JavaScript string literal
NativeWebView->>JavaScriptBridge: define injectedObjectJson()
JavaScriptBridge->>WebPage: return quoted object JSON
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)android/build.gradleTraceback (most recent call last): Comment |
Quote
injectedJavaScriptObjectJSON as a JavaScript string on Android and Apple platforms.Tests:
yarn lint, existing Jest suite, focused Java encoding harness.Summary by CodeRabbit
Bug Fixes
Tests