Skip to content

Dev Guide printing finalization - #911

Merged
Melkiades merged 6 commits into
mainfrom
715_reboot_dev_guide@main
Aug 15, 2024
Merged

Dev Guide printing finalization#911
Melkiades merged 6 commits into
mainfrom
715_reboot_dev_guide@main

Conversation

@Melkiades

@Melkiades Melkiades commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Fixes #715 (not really, it needs to be closed though imo, many comments are outdated and too long). mainly fix for pharmaverse/formatters#124

@github-actions

github-actions Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     27 suites   1m 44s ⏱️
  213 tests   213 ✅ 0 💤 0 ❌
1 570 runs  1 570 ✅ 0 💤 0 ❌

Results for commit e7e1b52.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               780      63  91.92%   20, 94, 97, 428, 519-520, 523, 681, 785, 877-878, 980, 983, 985-986, 1004-1007, 1027, 1142-1145, 1243-1248, 1404, 1504-1507, 1573-1576, 1612-1615, 1621-1626, 1677, 1684, 1778, 1886, 1899, 1902-1905, 1908-1911, 1938, 1969-1970
R/as_html.R                    167      25  85.03%   5-10, 77, 149-154, 159-164, 179-183, 270
R/colby_constructors.R         594      26  95.62%   81, 134, 197-200, 267-270, 410, 426, 1175, 1263, 1424, 1463, 1474, 1482, 1485, 1509, 1530, 1676, 1899-1902
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         286      22  92.31%   271, 334-337, 348-349, 351, 353, 549-553, 617-620, 683-686
R/format_rcell.R                12       0  100.00%
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             138      31  77.54%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 295, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      15  89.05%   35, 47-61, 135-142, 178, 267, 271, 280
R/simple_analysis.R              5       1  80.00%   56
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1120     140  87.50%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 426, 448-451, 566, 593-594, 880-886, 1030, 1049, 1075, 1127, 1184-1185, 1222, 1257, 1295-1300, 1359, 1433-1437, 1455-1464, 1542, 1657-1660, 1685, 1707-1708, 1718, 1769, 1790-1795, 1816-1821, 1832, 1906, 1947, 2046, 2153, 2166, 2180, 2196, 2205, 2215-2219, 2269-2274, 2477, 2487-2490, 2500, 2525-2528, 2535, 2537-2540, 2662, 2696-2697, 2754, 3059, 3420, 3536, 3570-3595, 3686-3694, 3847, 3921-3927, 4139-4140, 4147, 4150-4153, 4157, 4207, 4268, 4293-4317
R/tt_afun_utils.R              411      32  92.21%   48, 155, 162, 171-184, 250, 258-259, 477, 485-488, 570-574, 594, 608-610
R/tt_compare_tables.R           70       4  94.29%   51, 174, 246, 250
R/tt_compatibility.R           570      70  87.72%   19, 142-143, 186, 191, 319-320, 324-327, 333, 337, 521, 575-578, 615-617, 655, 688, 708, 728-731, 741-744, 789, 806-810, 816-819, 893, 920-923, 932, 994, 1002, 1013-1016, 1127, 1134, 1162-1176, 1207-1208
R/tt_dotabulation.R           1161      95  91.82%   54, 246, 251, 253, 301, 325, 329-332, 364-367, 390, 423-426, 454-457, 552, 690-694, 743, 747, 775-778, 788, 808-812, 819-822, 1082, 1086, 1117, 1220-1223, 1433-1441, 1705-1714, 1796-1799, 1810, 1815, 1820-1821, 1823, 1834, 1839, 1862, 1948-1967
R/tt_export.R                  513      31  93.96%   45, 183-187, 235-238, 290-293, 438, 444, 476, 528, 808, 817, 842-846, 1013-1016, 1019, 1050, 1056
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                513      37  92.79%   74, 122-131, 441, 576-579, 600-604, 749-752, 803-810, 887, 890, 908, 915, 918
R/tt_pos_and_access.R          571      42  92.64%   76, 78-80, 105, 166, 212-216, 258, 507, 509, 517, 523, 537, 547-550, 730, 733, 741-745, 750-753, 780, 833-834, 845, 1007-1008, 1076-1092, 1361, 1436
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    101       5  95.05%   245-248, 256
R/tt_toString.R                433      24  94.46%   123, 345, 367, 380, 390, 396, 399, 405-415, 508, 609, 811-836
R/utils.R                       29       0  100.00%
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         8504     800  90.59%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/tt_toString.R       -3      -3  +0.65%
TOTAL                 -3      -3  +0.03%

Results for commit: e7e1b52

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Comment thread vignettes/dev-guide/dg_printing.Rmd Outdated
Co-authored-by: Abinaya Yogasekaram <73252787+ayogasekaram@users.noreply.github.com>
Signed-off-by: Davide Garolini <dgarolini@gmail.com>

@ayogasekaram ayogasekaram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great @Melkiades

@Melkiades
Melkiades merged commit a674d13 into main Aug 15, 2024
@Melkiades
Melkiades deleted the 715_reboot_dev_guide@main branch August 15, 2024 07:41
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate some of the dev guide code comments to the main code base

2 participants