first UI support for assemblies#162
Conversation
| { #category : #execution } | ||
| PBCreateAssemblyCommand class >> execute [ | ||
|
|
||
| ^ self name , ' Assembly' |
There was a problem hiding this comment.
Yeah, this looks wrong, probably I did a mistake because of Calypso saving dirty methods...
| CGOCreatePackageInProjectCommand >> createSystemPackage [ | ||
| PBCreatePackageInProjectCommand >> createSystemPackage [ | ||
| SycAddNewPackageCommand new | ||
| systemEnvironment: toolContext systemEnvironment; |
There was a problem hiding this comment.
Normally commands should not reference context. They should be self contained objects and extract required collaborators from context. Here it means that command should have variable #systemEnvironment.
But I did not look deeply. In some cases keeping context is suitable workaround.
There was a problem hiding this comment.
I don't see a reason against nor in favour. Can you elaborate?
| @@ -0,0 +1,207 @@ | |||
| Class { | |||
| #name : #PBSelectPackagesDialog, | |||
There was a problem hiding this comment.
Notice that there is reusable search dialog in Calypso. For packages it would be:
^browser searchDialog requestSingleObject: 'Select package' from: ClyAllPackages sortedThere was a problem hiding this comment.
That's not useful for Cargo. I want to control what are the packages that are shown, that dialog is supposed to be reusable in different context and not only show system packages.
2 participants
Fix #156