22288-The-changes-in-21855-affect-old-extension-methods-that-are-not-case-equals#1663
Merged
Conversation
… old packages. Fix #22288
tesonep
approved these changes
Jul 30, 2018
guillep
deleted the
22288-The-changes-in-21855-affect-old-extension-methods-that-are-not-case-equals
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pharo.fogbugz.com/f/cases/22288/The-changes-in-21855-affect-old-extension-methods-that-are-not-case-equals
In 21855 the comparison of MCPackages was made case sensitive. This has problems when there are extension methods that are wrongly defined... For example, loading JSON 1.2
Metacello new
configuration: 'JSON';
repository: 'http://smalltalkhub.com/mc/PharoExtras/JSON/main/';
version: '1.2';
load.
will create two packages in latest pharo 7 (JSON, Json-printing). The second package is indeed wrong, it is created because the a method has "*Json-printing" as protocol, instead of "*JSON".
This PR introduces a case insensitive comparison of protocols when installing extension methods to be able to load old packages with wrong protocols.