chore: update coverage stats and badges#18
Merged
Conversation
matthewevans
enabled auto-merge (squash)
April 8, 2026 16:56
lgray
added a commit
to lgray/phase
that referenced
this pull request
Jul 14, 2026
The prior planning docs describe an engine that no longer exists. Re-measured every load-bearing citation against main @ efc76ca (the docs were written against a tree 768 commits behind) and two central claims are refuted: - "there is no live object-growth path" -> FALSE. try_offer_object_growth_shortcut drives the captured recast on a clone (game/engine.rs:1656). - "the offer carries no iteration count" -> FALSE. ShortcutDecisionSchema .iteration_count: IterationCount::{Fixed,UntilLethal} (decision_template.rs:203). PR-7 shipped ~90% of the spec. The live blocker is REACHABILITY, not capability: fire_time_conditions_read_growing_class (resource.rs:1457, consumed by two gates) vetoes if ANY object in scope trips ability_reads_sibling_mutable -- and sibling:true is the fail-closed DEFAULT for typed filters (ability_scan.rs:2420, "stay CONSERVATIVE"). 84 such sites on main (54 Axes::CONSERVATIVE + 30 sibling:true). Each is individually rules-correct; the firewall is a disjunction over ~100 Commander permanents, so composed they veto by construction. The suite missed it because its fixtures build boards that cannot exist (no lands, empty library). New: LOOP-SHORTCUT-SPEC-AND-STATE.md -- spec, verified CR/MTR layer, what main already does (do not rebuild), why it never fires, and the one experiment that decides the rest (stub the firewall to always-accept, port the fixture, run it). The six prior docs are banner-marked STALE (historical only; rules reasoning and soundness rules still good, code facts not). Also repaired their internal integrity first, so the archive is at least self-consistent: Appendix B now runs 1..19 in order (phase-rs#18 was filed before phase-rs#17, and phase-rs#19 was an IOU), the MTR addendum no longer sits above the section titled "READ THIS FIRST", and the error count is no longer simultaneously 17, 18, and 19 in one document. Assisted-by: ClaudeCode:claude-opus-4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated update of README coverage badges from latest card data.